Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Contact Us Emails- First Line Missing


nixona

Recommended Posts

I installed everything as needed to get my secure SMTP with port to send mail. Mail is now being sent and everything going out to customers looks great. However when someone uses the contact us method to send an email, the first line is cut off. So basically anything put into the form before the user hits enter is not coming through. Am I right that this is handled through general.php ? No changes were made there, I compared it to the original file and there are no differences. Am I missing something small or could there be an issue in email.php or mail.php which I did change? Any help would be greatly appreciated. Thanks.

Link to comment
Share on other sites

Any help here? First line of contact us emails floats off into cyberspace...I can actually fill out the form using:

 

Line 1

Line 2

Line 3

Line 4

and so on....

 

And everything will come through perfectly with the exception of Line 1. What kills me is my catalog got hosed by hardware failure but this was working in July with no problems at all...I'd be happy to post code if I could figure out what to post...

Link to comment
Share on other sites

  • 2 weeks later...

Here's my email.php I have a feeling the problem is in here:

 

<?php
/*
 $Id: email.php,v 1.12 2003/06/17 17:29:44 dgw_ Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License

 mail.php - a class to assist in building mime-HTML eMails

 The original class was made by Richard Heyes <[email protected]>
 and can be found here: http://www.phpguru.org

 Renamed and Modified by Jan Wildeboer for osCommerce
*/

 class email {
var $html;
var $text;
var $output;
var $html_text;
var $html_images;
var $image_types;
var $build_params;
var $attachments;
var $headers;

function email($headers = '') {
  if ($headers == '') $headers = array();

  $this->html_images = array();
  $this->headers = array();

  if (EMAIL_LINEFEED == 'CRLF') {
	$this->lf = "\r\n";
  } else {
	$this->lf = "\n";
  }

/**
* If you want the auto load functionality
* to find other mime-image/file types, add the
* extension and content type here.
*/

  $this->image_types = array('gif' => 'image/gif',
							 'jpg' => 'image/jpeg',
							 'jpeg' => 'image/jpeg',
							 'jpe' => 'image/jpeg',
							 'bmp' => 'image/bmp',
							 'png' => 'image/png',
							 'tif' => 'image/tiff',
							 'tiff' => 'image/tiff',
							 'swf' => 'application/x-shockwave-flash');

  $this->build_params['html_encoding'] = 'quoted-printable';
  $this->build_params['text_encoding'] = '7bit';
  $this->build_params['html_charset'] = constant('CHARSET');
  $this->build_params['text_charset'] = constant('CHARSET');
  $this->build_params['text_wrap'] = 998;

/**
* Make sure the MIME version header is first.
*/

  $this->headers[] = 'MIME-Version: 1.0';

  reset($headers);
  while (list(,$value) = each($headers)) {
	if (tep_not_null($value)) {
	  $this->headers[] = $value;
	}
  }
}

/**
* This function will read a file in
* from a supplied filename and return
* it. This can then be given as the first
* argument of the the functions
* add_html_image() or add_attachment().
*/

function get_file($filename) {
  $return = '';

  if ($fp = fopen($filename, 'rb')) {
	while (!feof($fp)) {
	  $return .= fread($fp, 1024);
	}
	fclose($fp);

	return $return;
  } else {
	return false;
  }
}

/**
* Function for extracting images from
* html source. This function will look
* through the html code supplied by add_html()
* and find any file that ends in one of the
* extensions defined in $obj->image_types.
* If the file exists it will read it in and
* embed it, (not an attachment).
*
* Function contributed by Dan Allen
*/

function find_html_images($images_dir) {
// Build the list of image extensions
  while (list($key, ) = each($this->image_types)) {
	$extensions[] = $key;
  }

  preg_match_all('/"([^"]+\.(' . implode('|', $extensions).'))"/Ui', $this->html, $images);

  for ($i=0; $i<count($images[1]); $i++) {
	if (file_exists($images_dir . $images[1][$i])) {
	  $html_images[] = $images[1][$i];
	  $this->html = str_replace($images[1][$i], basename($images[1][$i]), $this->html);
	}
  }

  if (tep_not_null($html_images)) {
// If duplicate images are embedded, they may show up as attachments, so remove them.
	$html_images = array_unique($html_images);
	sort($html_images);

	for ($i=0; $i<count($html_images); $i++) {
	  if ($image = $this->get_file($images_dir . $html_images[$i])) {
		$content_type = $this->image_types[substr($html_images[$i], strrpos($html_images[$i], '.') + 1)];
		$this->add_html_image($image, basename($html_images[$i]), $content_type);
	  }
	}
  }
}

/**
* Adds plain text. Use this function
* when NOT sending html email
*/

function add_text($text = '') {
  $this->text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);
}

/**
* Adds a html part to the mail.
* Also replaces image names with
* content-id's.
*/

function add_html($html, $text = NULL, $images_dir = NULL) {
  $this->html = tep_convert_linefeeds(array("\r\n", "\n", "\r"), '<br>', $html);
  $this->html_text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);

  if (isset($images_dir)) $this->find_html_images($images_dir);
}

/**
* Adds an image to the list of embedded
* images.
*/

function add_html_image($file, $name = '', $c_type='application/octet-stream') {
  $this->html_images[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'cid' => md5(uniqid(time())));
}

/**
* Adds a file to the list of attachments.
*/

function add_attachment($file, $name = '', $c_type='application/octet-stream', $encoding = 'base64') {
  $this->attachments[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'encoding' => $encoding);
}

/**
* Adds a text subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_text_part(&$obj, $text) {
function add_text_part(&$obj, $text) {
  $params['content_type'] = 'text/plain';
  $params['encoding'] = $this->build_params['text_encoding'];
  $params['charset'] = $this->build_params['text_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($text, $params);
  } else {
	return new mime($text, $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_part(&$obj) {
function add_html_part(&$obj) {
  $params['content_type'] = 'text/html';
  $params['encoding'] = $this->build_params['html_encoding'];
  $params['charset'] = $this->build_params['html_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($this->html, $params);
  } else {
	return new mime($this->html, $params);
  }
}

/**
* Starts a message with a mixed part
*/

/* HPDL PHP3 */
//	function &add_mixed_part() {
function add_mixed_part() {
  $params['content_type'] = 'multipart/mixed';

  return new mime('', $params);
}

/**
* Adds an alternative part to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_alternative_part(&$obj) {
function add_alternative_part(&$obj) {
  $params['content_type'] = 'multipart/alternative';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_related_part(&$obj) {
function add_related_part(&$obj) {
  $params['content_type'] = 'multipart/related';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds an html image subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_image_part(&$obj, $value) {
function add_html_image_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = 'base64';
  $params['disposition'] = 'inline';
  $params['dfilename'] = $value['name'];
  $params['cid'] = $value['cid'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Adds an attachment subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_attachment_part(&$obj, $value) {
function add_attachment_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = $value['encoding'];
  $params['disposition'] = 'attachment';
  $params['dfilename'] = $value['name'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Builds the multipart message from the
* list ($this->_parts). $params is an
* array of parameters that shape the building
* of the message. Currently supported are:
*
* $params['html_encoding'] - The type of encoding to use on html. Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							7bit is EXPRESSLY NOT RECOMMENDED. Default is quoted-printable
* $params['text_encoding'] - The type of encoding to use on plain text Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							Default is 7bit
* $params['text_wrap']	 - The character count at which to wrap 7bit encoded data.
*							Default this is 998.
* $params['html_charset']  - The character set to use for a html section.
*							Default is iso-8859-1
* $params['text_charset']  - The character set to use for a text section.
*						  - Default is iso-8859-1
*/

/* HPDL PHP3 */
//	function build_message($params = array()) {
function build_message($params = '') {
  if ($params == '') $params = array();

  if (count($params) > 0) {
	reset($params);
	while(list($key, $value) = each($params)) {
	  $this->build_params[$key] = $value;
	}
  }

  if (tep_not_null($this->html_images)) {
	reset($this->html_images);
	while (list(,$value) = each($this->html_images)) {
	  $this->html = str_replace($value['name'], 'cid:' . $value['cid'], $this->html);
	}
  }

  $null = NULL;
  $attachments = ((tep_not_null($this->attachments)) ? true : false);
  $html_images = ((tep_not_null($this->html_images)) ? true : false);
  $html = ((tep_not_null($this->html)) ? true : false);
  $text = ((tep_not_null($this->text)) ? true : false);

  switch (true) {
	case (($text == true) && ($attachments == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_text_part($null, $this->text);
	  $message = $this->add_text_part($null, $this->text);
	  break;
	case (($text == false) && ($attachments == true) && ($html == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($text == true) && ($attachments == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  $this->add_text_part($message, $this->text);

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == false)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
		$this->add_html_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_html_part($null);
		$message = $this->add_html_part($null);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == true)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
/* HPDL PHP3 */
//			$related =& $this->add_related_part($message);
		$related = $this->add_related_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_related_part($null);
//			$related =& $message;
		$message = $this->add_related_part($null);
		$related = $message;
	  }
	  $this->add_html_part($related);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($related, $this->html_images[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
		$this->add_html_part($alt);
	  } else {
		$this->add_html_part($message);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($alt);
		$rel = $this->add_related_part($alt);
	  } else {
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($message);
		$rel = $this->add_related_part($message);
	  }
	  $this->add_html_part($rel);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($rel, $this->html_images[$i]);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
  }

  if ( (isset($message)) && (is_object($message)) ) {
	$output = $message->encode();
	$this->output = $output['body'];

	reset($output['headers']);
	while (list($key, $value) = each($output['headers'])) {
	  $headers[] = $key . ': ' . $value;
	}

	$this->headers = array_merge($this->headers, $headers);

	return true;
  } else {
	return false;
  }
}

/**
* Sends the mail.
*/

function send($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
  if ((strstr($to_name, "\n") != false) || (strstr($to_name, "\r") != false)) {
	return false;
  }

  if ((strstr($to_addr, "\n") != false) || (strstr($to_addr, "\r") != false)) {
	return false;
  }

  if ((strstr($subject, "\n") != false) || (strstr($subject, "\r") != false)) {
	return false;
  }

  if ((strstr($from_name, "\n") != false) || (strstr($from_name, "\r") != false)) {
	return false;
  }

  if ((strstr($from_addr, "\n") != false) || (strstr($from_addr, "\r") != false)) {
	return false;
  }

  $to = (($to_name != '') ? '"' . $to_name . '" <' . $to_addr . '>' : $to_addr);
  $from = (($from_name != '') ? '"' . $from_name . '" <' . $from_addr . '>' : $from_addr);

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }

 if (EMAIL_TRANSPORT == 'smtp') {

  include_once("Mail.php");

  $headers["From"]	= $from;
  $headers["To"]	  = $to_addr;
  $headers["Subject"] = $subject;
  $params["host"] = "xxxxxxxxxxx";
  $params["port"] = "80";
  $params["auth"] = true;
  $params["username"] = "xxxxxxxxxxxxx";
  $params["password"] = "xxxxxxxxxxx";

  // Create the mail object using the Mail::factory method
  $mail_object =& Mail::factory("smtp", $params);
  return $mail_object->send($to_addr, $headers, $this->output);
 }
  }
/**
* Use this method to return the email
* in message/rfc822 format. Useful for
* adding an email to another email as
* an attachment. there's a commented
* out example in example.php.
*
* string get_rfc822(string To name,
*	   string To email,
*	   string From name,
*	   string From email,
*	   [string Subject,
*		string Extra headers])
*/

function get_rfc822($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
// Make up the date header as according to RFC822
  $date = 'Date: ' . date('D, d M y H:i:s');
  $to = (($to_name != '') ? 'To: "' . $to_name . '" <' . $to_addr . '>' : 'To: ' . $to_addr);
  $from = (($from_name != '') ? 'From: "' . $from_name . '" <' . $from_addr . '>' : 'From: ' . $from_addr);

  if (is_string($subject)) {
	$subject = 'Subject: ' . $subject;
  }

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }

  $headers = array_merge($this->headers, $xtra_headers);

  return $date . $this->lf . $from . $this->lf . $to . $this->lf . $subject . $this->lf . implode($this->lf, $headers) . $this->lf . $this->lf . $this->output;
}
 }
?>

 

Any email sent using the contact us form shows up with the first line missing. Email transport method is SMTP, Linefeeds is CRLF, Use MIME is False, Verify Email addresses is False, Send Emails is true. Interestingly enough if I change it to MIME I get the entire message with the junk MIME header at the bottom. Any help would be much appreciated. Thanks.

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...