A Messy Fix needs a proper solution

[Antonimo]

Oh, what have I done? What has happened?

 

I have installed the phpbb2 contribution and I have not had any issues with it until now.

 

The link to the forum in the info box (information.php) is

'<a href="' . tep_href_link(FILENAME_BBMODULES, 'op=modload&name=phpbb2&file=index.php', 'NONSSL') . '">' . BOX_BBINDEX . '</a>');

(it is the last link in the list)

 

Following the link in the information box to "forum" is giving me an error

Warning: main(includes/modules//): failed to open stream: No such file or directory in /home/httpd/vhosts/domain.com/httpdocs/catalogue/modules.php on line 57

Warning: main(includes/modules//): failed to open stream: No such file or directory in /home/httpd/vhosts/domain.com/httpdocs/catalogue/modules.php on line 57

Warning: main(): Failed opening 'includes/modules//' for inclusion (include_path='.:') in /home/httpd/vhosts/domain.com/httpdocs/catalogue/modules.php on line 57

Line 57 of modules.php is

	 include(DIR_WS_MODULES."$name/$file");

I cannot find any missing or extra { and } brackets

 

I did a test by replacing the line with

	 include(DIR_WS_MODULES."phpbb2/index.php");

The link to the forum worked in as much as I reached the main forum page, thereafter, none of the links in the forum worked - they all refreshed the page, because every link became

http://www.domain.com/catalogue/modules.php?op=modload&name=phpbb2&file=viewforum.php&f=1&sid=......

So in modules.php I reverted back to

	 include(DIR_WS_MODULES."$name/$file");

and changed the link in the info box (information.php) to

 '<a href="modules.php?op=modload&name=phpbb2&file=index.php">forum</a>');

Now, everything appears to working correctly. The links to the forum and within the forum and back to the shop.

 

I am not happy <_< about the messy way that I (appear) to have fixed this and I hope that somebody can show me what I ought to have done to fix it properly.

[Antonimo]

Anyone?