wvlenthe Posted February 23, 2011 Share Posted February 23, 2011 Think i found a bug, in discount_coupon.php, function total_valid_products, there tax is calculated when DISPLAY_PRICE_WITH_TAX = true but an unknown array $tax_address is used causing tax to be always 0. So while the whole shop may be displaying prices with tax, the coupon-codes modules is calculating discounts always based on prices without tax (and then optionally adding tax again for displaying). All very confusing ... Paul Hello Paul, In my opinion, discounts should be calculated without tax to be able to work correctly. You don't want discounts including tax to be given when selling to non-EU countries, but you want to tax EU sales. There is an issue with tax calculation on shipping discounts. If this is the discount you are using, read back a page or two where you will find a fix by Suhy. This is a workaround and certainly not a definitive fix. As to the $tax_address, this variable is set in order.php on line 152 (my version of it anyway). discount_coupon.php is then called from here in lines 220 and further. If your tax percentage always comes back zero and you are not testing with shipping discount, I would say you need to check your tax setup. There is a good topic on the dutch forum on this by Berkedam). HTH Wiljo Quote Link to comment Share on other sites More sharing options...
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.