Product Notifications

vox · June 2, 2006

My store is nearly ready to go but I've found a problem in the final testing that I just cant find the answer to in the forums.

As a customer I can select the product notifications option from the Notifications Box on the product_info pages and that shows in my account.

But when I buy a product and select the product notifications option check box on the checkout_success pages it doesn't show in my account.

Can anyone point me in the right direction ??

Thanks

Bob

vox · June 3, 2006

It would help if I'd have remembered to post the code !!!

product_notifications works fine - adds the notification to my acount:

$info_box_contents = array();
$info_box_contents[] = array('text' => BOX_HEADING_NOTIFICATIONS);

new infoBoxHeading($info_box_contents, false, false, tep_href_link(FILENAME_ACCOUNT_NOTIFICATIONS, '', 'SSL'));

if (tep_session_is_registered('customer_id')) {
  $check_query = tep_db_query("select count(*) as count from " . TABLE_PRODUCTS_NOTIFICATIONS . " where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and customers_id = '" . (int)$customer_id . "'");
  $check = tep_db_fetch_array($check_query);

  $notification_exists = (($check['count'] > 0) ? true : false);
} else {
  $notification_exists = false;
}

$info_box_contents = array();
if ($notification_exists == true) {
  $info_box_contents[] = array('text' => '<table border="0" cellspacing="0" cellpadding="2"><tr><td class="infoBoxContents"><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=notify_remove', $request_type) . '">' . tep_image(DIR_WS_IMAGES . 'box_products_notifications_remove.gif', IMAGE_BUTTON_REMOVE_NOTIFICATIONS) . '</a></td><td class="infoBoxContents"><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=notify_remove', $request_type) . '">' . sprintf(BOX_NOTIFICATIONS_NOTIFY_REMOVE, tep_get_products_name($HTTP_GET_VARS['products_id'])) .'</a></td></tr></table>');
} else {
  $info_box_contents[] = array('text' => '<table border="0" cellspacing="0" cellpadding="2"><tr><td class="infoBoxContents"><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=notify', $request_type) . '">' . tep_image(DIR_WS_IMAGES . 'box_products_notifications.gif', IMAGE_BUTTON_NOTIFICATIONS) . '</a></td><td class="infoBoxContents"><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=notify', $request_type) . '">' . sprintf(BOX_NOTIFICATIONS_NOTIFY, tep_get_products_name($HTTP_GET_VARS['products_id'])) .'</a></td></tr></table>');

checkout_success looks as though it is working (no error codes) when I check the product notification box but it does not add the notification to my account:

if ($global['global_product_notifications'] != '1') {
echo TEXT_NOTIFY_PRODUCTS . '<br><p class="productsNotifications">';

$products_displayed = array();
for ($i=0, $n=sizeof($products_array); $i<$n; $i++) {
  if (!in_array($products_array[$i]['id'], $products_displayed)) {
	echo tep_draw_checkbox_field('notify[]', $products_array[$i]['id']) . ' ' . $products_array[$i]['text'] . '<br>';
	$products_displayed[] = $products_array[$i]['id'];
  }
}

echo '</p>';
 } else {
echo TEXT_SEE_ORDERS . '<br><br>' . TEXT_CONTACT_STORE_OWNER;
 }

vox · July 17, 2006

Could anyone give me a hint on how to tackle this ???

♥Monika in Germany · July 17, 2006

check if you have this line in your checkout_success.php

<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_CHECKOUT_SUCCESS, 'action=update', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

vox · July 17, 2006

Thanks for having a look.

Yes, I've got the code included at around line 82. (I've got the header tag controller contrib installed)

Do I need to "cut and paste" any of the working code from product notifications box into the checkout success page ?

♥Monika in Germany · July 17, 2006

nope ... can you post the whole checkout_success.php?

vox · July 17, 2006

Ok, here it is. Thanks for taking the time to look at it for me.

<?php
/*
 $Id: checkout_success.php,v 1.49 2003/06/09 23:03:53 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License
*/

 require('includes/application_top.php');

// if the customer is not logged on, redirect them to the shopping cart page
 if (!tep_session_is_registered('customer_id')) {
tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));
 }

 if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'update')) {
$notify_string = 'action=notify&';
$notify = $HTTP_POST_VARS['notify'];
if (!is_array($notify)) $notify = array($notify);
for ($i=0, $n=sizeof($notify); $i<$n; $i++) {
  $notify_string .= 'notify[]=' . $notify[$i] . '&';
}
if (strlen($notify_string) > 0) $notify_string = substr($notify_string, 0, -1);

tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string));
 }

 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CHECKOUT_SUCCESS);

 $breadcrumb->add(NAVBAR_TITLE_1);
 $breadcrumb->add(NAVBAR_TITLE_2);

 $global_query = tep_db_query("select global_product_notifications from " . TABLE_CUSTOMERS_INFO . " where customers_info_id = '" . (int)$customer_id . "'");
 $global = tep_db_fetch_array($global_query);

 if ($global['global_product_notifications'] != '1') {
$orders_query = tep_db_query("select orders_id from " . TABLE_ORDERS . " where customers_id = '" . (int)$customer_id . "' order by date_purchased desc limit 1");
$orders = tep_db_fetch_array($orders_query);

$products_array = array();
$products_query = tep_db_query("select products_id, products_name from " . TABLE_ORDERS_PRODUCTS . " where orders_id = '" . (int)$orders['orders_id'] . "' order by products_name");
while ($products = tep_db_fetch_array($products_query)) {
  $products_array[] = array('id' => $products['products_id'],
							'text' => $products['products_name']);
}
 }
?>
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>>
<head>
<?php
// BOF: Header Tag Controller v2.5.7
if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) {
 require(DIR_WS_INCLUDES . 'header_tags.php');
} else {
?> 
 <title><?php echo TITLE; ?></title>
<?php
}
// EOF: Header Tag Controller v2.5.7
?>
<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">
<link rel="stylesheet" type="text/css" href="stylesheet.css">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
<!-- header //-->
<?php require(DIR_WS_INCLUDES . 'header.php'); ?>
<!-- header_eof //-->

<!-- body //-->
<table border="0" width="100%" cellspacing="3" cellpadding="3">
 <tr>
<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- left_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>
<!-- left_navigation_eof //-->
</table></td>
<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_CHECKOUT_SUCCESS, 'action=update', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">
  <tr>
	<td><table border="0" width="100%" cellspacing="4" cellpadding="2">
	  <tr>
		<td valign="top"><?php echo tep_image(DIR_WS_IMAGES . 'table_background_man_on_board.gif', HEADING_TITLE); ?></td>
		<td valign="top" class="main"><?php echo tep_draw_separator('pixel_trans.gif', '1', '10'); ?><div align="center" class="pageHeading"><?php echo HEADING_TITLE; ?></div><br><?php echo TEXT_SUCCESS; ?><br><br>
<?php
 if ($global['global_product_notifications'] != '1') {
echo TEXT_NOTIFY_PRODUCTS . '<br><p class="productsNotifications">';

$products_displayed = array();
for ($i=0, $n=sizeof($products_array); $i<$n; $i++) {
  if (!in_array($products_array[$i]['id'], $products_displayed)) {
	echo tep_draw_checkbox_field('notify[]', $products_array[$i]['id']) . ' ' . $products_array[$i]['text'] . '<br>';
	$products_displayed[] = $products_array[$i]['id'];
  }
}

echo '</p>';
 } else {
echo TEXT_SEE_ORDERS . '<br><br>' . TEXT_CONTACT_STORE_OWNER;
 }
?>
		<h3><?php echo TEXT_THANKS_FOR_SHOPPING; ?></h3></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td align="right" class="main"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="0">
	  <tr>
		<td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
		  <tr>
			<td width="50%" align="right"><?php echo tep_draw_separator('pixel_silver.gif', '1', '5'); ?></td>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		  </tr>
		</table></td>
		<td width="25%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		<td width="25%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		<td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
		  <tr>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
			<td width="50%"><?php echo tep_image(DIR_WS_IMAGES . 'checkout_bullet.gif'); ?></td>
		  </tr>
		</table></td>
	  </tr>
	  <tr>
		<td align="center" width="25%" class="checkoutBarFrom"><?php echo CHECKOUT_BAR_DELIVERY; ?></td>
		<td align="center" width="25%" class="checkoutBarFrom"><?php echo CHECKOUT_BAR_PAYMENT; ?></td>
		<td align="center" width="25%" class="checkoutBarFrom"><?php echo CHECKOUT_BAR_CONFIRMATION; ?></td>
		<td align="center" width="25%" class="checkoutBarCurrent"><?php echo CHECKOUT_BAR_FINISHED; ?></td>
	  </tr>
	</table></td>
  </tr>
<?php if (DOWNLOAD_ENABLED == 'true') include(DIR_WS_MODULES . 'downloads.php'); ?>
</table></form></td>
<!-- body_text_eof //-->
<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- right_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>
<!-- right_navigation_eof //-->
</table></td>
 </tr>
</table>
<!-- body_eof //-->

<!-- footer //-->
<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>
<!-- footer_eof //-->
<br>
</body>
</html>
<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

♥Monika in Germany · July 17, 2006

your file looks fine, and as it uses the same switch in appl top as the other page this is weird. ....

do me a favor and find this in line 20

if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'update')) {
$notify_string = 'action=notify&';

$notify = $HTTP_POST_VARS['notify'];

if (!is_array($notify)) $notify = array($notify);

for ($i=0, $n=sizeof($notify); $i<$n; $i++) {

$notify_string .= 'notify[]=' . $notify[$i] . '&';

}

if (strlen($notify_string) > 0) $notify_string = substr($notify_string, 0, -1);

tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string));

}

replace by this

if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'update')) {
$notify_string = 'action=notify&';

$notify = $HTTP_POST_VARS['notify'];

if (!is_array($notify)) $notify = array($notify);

for ($i=0, $n=sizeof($notify); $i<$n; $i++) {

$notify_string .= 'notify[]=' . $notify[$i] . '&';

}

if (strlen($notify_string) > 0) $notify_string = substr($notify_string, 0, -1);

echo $notify_string;

// tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string)); }

then choose products for notification, hit continue and let me know what text comes up at the top

vox · July 17, 2006

I've done that but I can't get to checkout success. When I hit order confirmation I get:

Parse error: parse error, unexpected $ in /***********/shop/checkout_success.php on line 163

Line 163 is the last line and is:

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

vox · July 17, 2006

OK I found what I'd done wrong. I moved the } down off the commented line and it worked.

The text I see when I tick the box and continue is:

action=notify&notify[]=20

♥Monika in Germany · July 17, 2006

ah sorry for the bracket I didn't check it, the quote feature tends to move lines together ...

ok that looks fine, so you can remove it

next in application top in the notify switch stament, add an echo for the sql stuff ...

for ($i=0, $n=sizeof($notify); $i<$n; $i++) {
$check_query = tep_db_query("select count(*) as count from " . TABLE_PRODUCTS_NOTIFICATIONS . " where products_id = '" . $notify[$i] . "' and customers_id = '" . $customer_id . "'");

echo "select count(*) as count from " . TABLE_PRODUCTS_NOTIFICATIONS . " where products_id = '" . $notify[$i] . "' and customers_id = '" . $customer_id . "'<br>"; $check = tep_db_fetch_array($check_query);

if ($check['count'] < 1) {

tep_db_query("insert into " . TABLE_PRODUCTS_NOTIFICATIONS . " (products_id, customers_id, date_added) values ('" . $notify[$i] . "', '" . $customer_id . "', now())");

echo "insert into " . TABLE_PRODUCTS_NOTIFICATIONS . " (products_id, customers_id, date_added) values ('" . $notify[$i] . "', '" . $customer_id . "', now())<br>";

}

vox · July 17, 2006

I think I'm doing something wrong. I've added the code in bold from your post but when I tick the box and then hit continue it just takes me back to the homepage. There's no message displayed like the last time.

I've amended shop/includes/application_top.php so lines 397 - 406 so it now looks like this:

for ($i=0, $n=sizeof($notify); $i<$n; $i++) {
							  $check_query = tep_db_query("select count(*) as count from " . TABLE_PRODUCTS_NOTIFICATIONS . " where products_id = '" . $notify[$i] . "' and customers_id = '" . $customer_id . "'");
							  echo "select count(*) as count from " . TABLE_PRODUCTS_NOTIFICATIONS . " where products_id = '" . $notify[$i] . "' and customers_id = '" . $customer_id . "'<br>";
							  $check = tep_db_fetch_array($check_query);
							  if ($check['count'] < 1) {
								tep_db_query("insert into " . TABLE_PRODUCTS_NOTIFICATIONS . " (products_id, customers_id, date_added) values ('" . $notify[$i] . "', '" . $customer_id . "', now())");
							   echo "insert into " . TABLE_PRODUCTS_NOTIFICATIONS . " (products_id, customers_id, date_added) values ('" . $notify[$i] . "', '" . $customer_id . "', now())<br>";
							  }
							}
							tep_redirect(tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action', 'notify'))));

♥Monika in Germany · July 17, 2006

nope, my bad ... we need to comment out the redirect also.

//tep_redirect(tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action', 'notify'))));

vox · July 17, 2006

That's no problem at all - I really appreciate your help.

I've now commented out the line but it is still the same. There is no text showing up, I just go straight back to the homepage.

♥Monika in Germany · July 17, 2006

That's no problem at all - I really appreciate your help.

I've now commented out the line but it is still the same. There is no text showing up, I just go straight back to the homepage.

okies, I tried it on a default install ... doesn't work. I normally remove this from my designs, as I do not like it, so I have never really tested it. It seems it logs you out also, so it probably goes right to the else here

								} else {
							  tep_redirect(tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action', 'notify'))));
							}

let me know if you need the feature, I can try to fix it (I may need it one day in a project :-))

vox · July 17, 2006

Thank you very much for all your help and advice (and the time you've spent today).

I'll play with that section in application_top.php and see if I can make any progress.

Once again thanks for you help and have a good evening.

♥Monika in Germany · July 17, 2006

I found it .... the call in checkout_success.php has been faulty all along

change to this and you are set!

<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_CHECKOUT_SUCCESS, 'action=notify', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

vox · July 17, 2006

That's great, thank you.

That's now fixed the product notification, but when I hit continue it doesn't transfer me back to the homepage.

Looks like I've still got some reading to do.

♥Monika in Germany · July 17, 2006

change this

<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_CHECKOUT_SUCCESS, 'action=notify', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

to this

<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_DEFAULT, 'action=notify', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

vox · July 17, 2006

I've checked again and it looks like everything is back as it was.

When

action=notify

it registers the notification but doesn't return me to homepage

but

when

action=update

it returns me to the homepage but doesn't register the update

I think you're right, I might just comment out the product notification option in checkout_success.

♥Monika in Germany · July 17, 2006

I've checked again and it looks like everything is back as it was.

When it registers the notification but doesn't return me to homepage

but

when it returns me to the homepage but doesn't register the update

I think you're right, I might just comment out the product notification option in checkout_success.

did you see my post #19? I edited it completely after running a test ... works perfectly for me now ...

vox · July 17, 2006

No, It still goes one way or the other. I've copied post #19 and that updates the notification but doesn't return me to the homepage.

Looks like I'll have to leave it like it is or uninstall my contributions one by one until I get to a point where it works. (Register Globals, Header Tags Controller,Ultimate SEO URLs, Dynamic Sitemap, VVC e-mail Security, Image Magic). Although none seem to impact the checkout_success code.

Thank you very much for all your time and effort helping me, I really appreciate it.

♥Monika in Germany · July 17, 2006

No, It still goes one way or the other. I've copied post #19 and that updates the notification but doesn't return me to the homepage.

Looks like I'll have to leave it like it is or uninstall my contributions one by one until I get to a point where it works. (Register Globals, Header Tags Controller,Ultimate SEO URLs, Dynamic Sitemap, VVC e-mail Security, Image Magic). Although none seem to impact the checkout_success code.

Thank you very much for all your time and effort helping me, I really appreciate it.

Bob, that's not possible ... the code I posted cannot take you to any othr page than FILENAME_DEFAULT which is the homepage ... you did get the bottom code?

It has FILENAME_DEFAULT and notify as action ...

It's been a long day and I just finally found a solutioh to a bug in a project code (after a nasty 60 minutes), so I feel your frustration. Please double check anyway, ok?

vox · July 17, 2006

I think I've got the code in the right place. Here's the code lines from line 82 in checkout_success:

<!-- body_text //-->
<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_CHECKOUT_SUCCESS, 'action=notify', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

♥Monika in Germany · July 17, 2006

nope!!!!

this is correct

<td width="100%" valign="top"><?php echo tep_draw_form('order', tep_href_link(FILENAME_DEFAULT, 'action=notify', 'SSL')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

Product Notifications

Recommended Posts

vox

vox

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

vox

♥Monika in Germany

Archived

Browse

Activity