Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Problems with header


Tormenta

Recommended Posts

Posted

I'm trying to change the osCommerce logo for my store's and I would like to have a design on the whole header area. I'm finishing with the layout of the store and made quite a few changes already.

 

The problem I find is that there is a distance between the left margin and the logo of about 1 cm and a half(maybe due to all the changes I made) and doesn't matter the size of whatever file.gif I upload, this margin remains with the background colour.

 

My header.php file is as follows:

 

_______________________________________________________

 

<?php

/*

$Id: header.php,v 1.42 2003/06/10 18:20:38 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Copyright © 2003 osCommerce

Released under the GNU General Public License

*/

// check if the 'install' directory exists, and warn of its existence

if (WARN_INSTALL_EXISTENCE == 'true') {

if (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/install')) {

$messageStack->add('header', WARNING_INSTALL_DIRECTORY_EXISTS, 'warning');

}

}

// check if the configure.php file is writeable

if (WARN_CONFIG_WRITEABLE == 'true') {

if ( (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) && (is_writeable(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) ) {

$messageStack->add('header', WARNING_CONFIG_FILE_WRITEABLE, 'warning');

}

}

// check if the session folder is writeable

if (WARN_SESSION_DIRECTORY_NOT_WRITEABLE == 'true') {

if (STORE_SESSIONS == '') {

if (!is_dir(tep_session_save_path())) {

$messageStack->add('header', WARNING_SESSION_DIRECTORY_NON_EXISTENT, 'warning');

} elseif (!is_writeable(tep_session_save_path())) {

$messageStack->add('header', WARNING_SESSION_DIRECTORY_NOT_WRITEABLE, 'warning');

}

}

}

// check session.auto_start is disabled

if ( (function_exists('ini_get')) && (WARN_SESSION_AUTO_START == 'true') ) {

if (ini_get('session.auto_start') == '1') {

$messageStack->add('header', WARNING_SESSION_AUTO_START, 'warning');

}

}

if ( (WARN_DOWNLOAD_DIRECTORY_NOT_READABLE == 'true') && (DOWNLOAD_ENABLED == 'true') ) {

if (!is_dir(DIR_FS_DOWNLOAD)) {

$messageStack->add('header', WARNING_DOWNLOAD_DIRECTORY_NON_EXISTENT, 'warning');

}

}

if ($messageStack->size('header') > 0) {

echo $messageStack->output('header');

}

?>

<div id="holder"><div id="innerholder">

<table border="0" width="100%" cellspacing="30" cellpadding="0">

<tr class="header">

<td align="left" valign="middle" width="553px"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image(DIR_WS_IMAGES . 'oscommerce.gif', 'osCommerce') . '</a>'; ?></td>

<td align="center" valign="middle"></*?php require(DIR_WS_BOXES . 'search.php'); ?*/> </td>

</tr>

</table>

<table border="0" width="100%" cellspacing="0" cellpadding="0">

<tr class="headerNavigation">

<td class="headerNavigation" height="20px">??<?php echo $breadcrumb->trail(' ? '); ?></td>

<td align="right" class="headerNavigation" height="16px"><?php if (tep_session_is_registered('customer_id')) { ?><a href="<?php echo tep_href_link(FILENAME_LOGOFF, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_LOGOFF; ?></a> ?|? <?php } ?><a href="<?php echo tep_href_link(FILENAME_ACCOUNT, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_MY_ACCOUNT; ?></a> ?|? <a href="<?php echo tep_href_link(FILENAME_SHOPPING_CART); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CART_CONTENTS; ?></a> ?|? <a href="<?php echo tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CHECKOUT; ?></a> ??</td>

</tr>

</table>

<table border="0" width="100%" cellspacing="0" cellpadding="1">

 

</table>

<?php

if (isset($HTTP_GET_VARS['error_message']) && tep_not_null($HTTP_GET_VARS['error_message'])) {

?>

<table border="0" width="100%" cellspacing="0" cellpadding="2">

<tr class="headerError">

<td class="headerError"><?php echo htmlspecialchars(urldecode($HTTP_GET_VARS['error_message'])); ?></td>

</tr>

</table>

<?php

}

if (isset($HTTP_GET_VARS['info_message']) && tep_not_null($HTTP_GET_VARS['info_message'])) {

?>

<table border="0" width="100%" cellspacing="0" cellpadding="2">

<tr class="headerInfo">

<td class="headerInfo"><?php echo htmlspecialchars($HTTP_GET_VARS['info_message']); ?></td>

</tr>

</table>

<?php

}

?>

 

_______________________________________________________

 

Does someone have an idea of why is this margin there, and how can I get rid of it?

 

Thank you!

Posted

Are you looking at your site using IE or Firefox browsers? If the gap isn't there in Firefox then it's an IE CSS bug.

 

Vger

Posted

I thank you once more for your precious help Vger. I use IE but, what does it mean "an IE CSS bug"? (Sorry, my english betrays me sometimes ....)

Posted

Different browsers handle CSS differently. None are 100% compatible with CSS Guidelines as laid down by the W3C Org, but Firefox is more compatible than IE.

 

Also osCommerce MS2 uses an invalid Doc Type in its root level files. Try changing the Doc Type of your root level files to this:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

 

Vger

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...