Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Recommended Posts

Posted

Just done some more testing. Whatever stops the coupon redemption working is set by completing the order or logging off. The first time you try to redeem a coupon it doesn't work, but then if you go through the redemption stage and then go back to cart contents it carries on working correctly. I've tried it in both IE and Firefox and it behaves the same way in both.

 

I'm sure it has to be something simple.

 

Ian

Posted
Hi Fredrik,

 

Maybe it's an idea to install the full CCGV (trad) and just not use the gv functions. After all, they don't have to use the GV functions do they? It's easier to just install the full package and not use the gv functions... anyway, they may want to use them at a later date so it will save you the hassle of finding a way to install the gv function at a later date.... no?

 

Or you can take out the admin gv page and keep the coupons instead.

 

Thank you Aleem. Yes, that is probably the best way. Vouchers are not even calculated the right way when using some of the payment modules I am using and there seems to be other problems with vouchers aswell. So I will remove the option of using vouchers in admin.

Posted

Ian, the problems you are having have nothing directly to do with this contribution. I know this because of all of the testing I have done on it.

 

And unfortunately, it's no good me trying to guess what it is about your own website's particular setup that is making it behave differently, because I have no knowledge of your site files.

 

Vger

Posted
Ian, the problems you are having have nothing directly to do with this contribution. I know this because of all of the testing I have done on it.

 

And unfortunately, it's no good me trying to guess what it is about your own website's particular setup that is making it behave differently, because I have no knowledge of your site files.

 

Vger

 

 

I appreciate that it is not directly to do with the contribution Vger. All I am asking is, with your extensive knowledge of the code, what sort of things could cause this to happen. Guesses are fine, I'll work through them until I find the problem. Are there any recommended setings for OSC to use this, regarding cookies and caching. Could it be something to do with the cc_id not being registered, or being registered when it shouldn't.

 

I don't know PHP but have loads of programming experience in other languages, so if you can give me some ideas I may be able to find it. Without them I am just going to have to dump the contribution and try to find another way to give discounts, which would be a shame.

 

Ian

Posted (edited)
Thank you Aleem. Yes, that is probably the best way. Vouchers are not even calculated the right way when using some of the payment modules I am using and there seems to be other problems with vouchers aswell. So I will remove the option of using vouchers in admin.

Firstly, just replace your CCGV with Vger's CCGV (trad) and remember to back up everything. PLEASE back-up!

 

Once that's done you can post here if you have any problems related specifically to CCGV. The easiest method would be to use the way suggest and just remove the GV link in the admin/coupon box - simple :-)

Edited by chooch

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Posted

It's only one guess, but I'd suspect the Best Login Box contribution - if that's the one you are using. I have known it to mess up other contributions (though don't know why it does this). If you have Pay Without Account installed then that would be a definite culprit.

 

Vger

I appreciate that it is not directly to do with the contribution Vger. All I am asking is, with your extensive knowledge of the code, what sort of things could cause this to happen. Guesses are fine, I'll work through them until I find the problem. Are there any recommended setings for OSC to use this, regarding cookies and caching. Could it be something to do with the cc_id not being registered, or being registered when it shouldn't.

 

I don't know PHP but have loads of programming experience in other languages, so if you can give me some ideas I may be able to find it. Without them I am just going to have to dump the contribution and try to find another way to give discounts, which would be a shame.

 

Ian

Posted
It's only one guess, but I'd suspect the Best Login Box contribution

 

Vger

 

Thanks, I'm using Best Login Box so I'll take a look at that. Any ideas what about it messes up someother contributions?

 

Ian

Posted

As I said - I have no real idea - but I do know that it is not an https login and so that may have something to do with it.

 

Vger

Posted

hello all

 

I've installed this mod and the only problem I have is that when I redeem a coupon I have to do this twice for it to show in checkout_confirmation.

My host is set to Register Globals off - I don't know if this is part of the problem as my php knowledge is pretty scarce and more hit and miss than anything.

 

Does anyone know how I could update the code so that it duplicates the submit entry (perhaps this would work) or have any other suggestions on working round this little glitch or refreshes the checkout_confirmation page twice as this seems to apply the discount and update the order when I try manually.

 

Thanks for any help in advance.

 

Sarah

Posted

This contribution wasn't written to work with Register Globals off, as the default osCommerce doesn't work with register globals 'off' either.

 

You can try putting a file called php.ini on your website (at the same level as you have your osCommerce website) with Register Globals set to On in that file.

 

Vger

Posted

I installed CCGV earlier today and I've come up with a few questions at this point;

 

1, When inserting a new coupon and choosing start date and end date it forgets these dates when editing the coupon later.

 

2, If I choose a valid category (for example "59"), will this override my empty valid product list? I think it should?

 

3, I choosed a valid category and then added one product from that category and another non valid product to the cart. Then I filled in the coupon code but I got no discount at all (the valid product list was leaved blank when inserting the coupon in admin)

 

4, If I leave "Uses per coupon" blank it adds a zero in this field which results in that no one can actually use the coupon. It sais that leave blank for no limit but it doesnt work?

 

I went through the installation carefully, but is it obvious that I've missed something very important?

Posted

Also, is there a fix to get the right order amounts in for example "Customer Orders-Total" and "Sales Report 2" when using coupons?

Posted (edited)
I installed CCGV earlier today and I've come up with a few questions at this point;

 

1, When inserting a new coupon and choosing start date and end date it forgets these dates when editing the coupon later.

 

2, If I choose a valid category (for example "59"), will this override my empty valid product list? I think it should?

 

3, I choosed a valid category and then added one product from that category and another non valid product to the cart. Then I filled in the coupon code but I got no discount at all (the valid product list was leaved blank when inserting the coupon in admin)

 

4, If I leave "Uses per coupon" blank it adds a zero in this field which results in that no one can actually use the coupon. It sais that leave blank for no limit but it doesnt work?

 

I went through the installation carefully, but is it obvious that I've missed something very important?

1. When coupons are edited they have a new start and end date - thats what was happening in your other CCGV install.

 

2. It should overide it in the sense that the coupon is valid while an item from that category is in the cart.

 

3. If the conditions of that coupon were being met (minmum price to redeemed etc) then it should work. Did you try taking the non item out and redeeming?

 

4. It does work with mine. Did you install all the pages or still use some from the other CCGV?

 

" Also, is there a fix to get the right order amounts in for example "Customer Orders-Total" and "Sales Report 2" when using coupons? "

 

...ummm, that question may be better suited to the other two forums (I think)

Edited by chooch

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Posted (edited)
1. When coupons are edited they have a new start and end date - thats what was happening in your other CCGV install.

 

2. It should overide it in the sense that the coupon is valid while an item from that category is in the cart.

 

3. If the conditions of that coupon were being met (minmum price to redeemed etc) then it should work. Did you try taking the non item out and redeeming?

 

4. It does work with mine. Did you install all the pages or still use some from the other CCGV?

 

" Also, is there a fix to get the right order amounts in for example "Customer Orders-Total" and "Sales Report 2" when using coupons? "

 

...ummm, that question may be better suited to the other two forums (I think)

 

Hi Aleem,

 

1, Ok, thanks, then I know

 

2, Ok

 

3, I just found out whats not working. It gets wrong when a product is assigned to several categories. For example; I choosed category "Our favourites" as valid. The product I was added to cart and tried to redeem is in category "Our favourites" but it's "main category" is "skin care". It was added to "skin care" and then copied/linked to "Our Favourites" (not duplicated). When I choosed "Skin Care" as valid in coupon admin it worked... This is an issue I do not know how to solve. Also, there are no error messages like "The code you are trying to redeem are not valid for the products in your cart" (or something like that)

 

4, I completely removed CCGV 5.14 before installning this one. Strange. I found out it only sais "0" in the Discount Coupons list BUT if I edit a coupon it will prefill "0"..

 

5, Well, the report "Customer Orders-Total" is standard in osCommerce (?)

Edited by Fredrik.r
Posted (edited)

hmmm.... very interesting, there is a problem somewhere with the coupon admin file.

 

One example is when I created a coupon and then edited it, by changing removing the % off the end. I then went back and tried to add the % at the end again but even though it showed up in the preview - it went back to ?20 in the right hand column of the coupon admin page...

 

After extensive testing I found that if categories or products are applied (using treeview or manual update) then Fredrik is right, things do go wrong, so much so that my actual order total before checkout was not calculating correctly! The % wasn't calculating correctly until I de-selected the free shipping and removed the categories/products limitations.

 

I found that if the shipping box is checked then the % cant be added after the second edit, in other words somehow you can't select a % discount if you select free shipping because even though the preview shows it as successful, the main admin coupon page shows that it didn't edit correctly in the column right :-(

 

This definately didn't happen pre-CCGV trad install. Hopefully Vger will take a look in greater detail.

 

Thanks for pointing that out Fredrik.

Edited by chooch

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Posted

Hi Vger

 

Thanks for your suggestion, I tried it and it still doesn't work (unless I have done something wrong). I wondered if you (or anyone) had any other ideas as I don't understand why when I redeem the voucher it doesn't work yet when I press the Refresh button on the checkout confirmation page it then correctly shows the discount. What could be happening to stop it originally working and then being ok when the page is refreshed?

 

Is there anything I can add in to get it to automatically refresh when they press the redeem voucher button so that the discount is applied automatically. I am not getting any error messages (that I can see(

 

Thanks in advance

 

Sarah

Posted
Hi Vger

 

Thanks for your suggestion, I tried it and it still doesn't work (unless I have done something wrong). I wondered if you (or anyone) had any other ideas as I don't understand why when I redeem the voucher it doesn't work yet when I press the Refresh button on the checkout confirmation page it then correctly shows the discount. What could be happening to stop it originally working and then being ok when the page is refreshed?

 

I've just tested that on my installation and exactly the same thing happens. I thought I had to go through the checkout process again to make it work but pressing refresh causes the voucher to show up correctly.

 

Glad it isn't just me. :)

Posted

Okay, there are obviously some issues that some people are having. So before I try to deal with those issues there are some things I need to know please.

 

1. Which version of PHP is being used

2. Is Register Globals set to 'off' on your server

3. What version of MySQL is being used

4. Did you make sure to update to the latest version of MS2 (November 2005), because this contribution is based on the updated MS2 file set

5. If you had another version of CCGV installed did you completely delete that version - revert all modified files back to their originals, delete the database tables etc.

6. What other (if any) contributions do you have installed.

 

Please post your replies here and I'll take a look and see if I can replicate the problem. Just don't expect it to be done immediately!

 

Vger

Posted

Hi Vger

 

Thanks for looking at this

 

1. Which version of PHP is being used

PHP 4.3.11

 

2. Is Register Globals set to 'off' on your server

Yes (host UK2)

 

3. What version of MySQL is being used

MySQL 4.0.24

 

4. Did you make sure to update to the latest version of MS2 (November 2005), because this contribution is based on the updated MS2 file set

 

I didn't update the sessions part (because my sessions.php has references to register globals and when I tried changing it, the new one wouldn't work).

 

5. If you had another version of CCGV installed did you completely delete that version - revert all modified files back to their originals, delete the database tables etc.

N/A

 

6. What other (if any) contributions do you have installed.

Back Button

CVV (one with blacklist)

Image Magic

Advanced Cartbox

Recover Cart Sales

Froogle

Googlesitemaps

Master Password

Register Globals

RM Shipping Rates

(I think this is all of the ones I have done)

 

Thank you for any suggestions or tips in getting this to work

 

Sarah

Posted
I didn't update the sessions part (because my sessions.php has references to register globals and when I tried changing it, the new one wouldn't work).

 

Just to let you know - the latest Register Globals Patch by CMOTD (Richard Bentley) has been updated to work with the new version of MS2.

 

Vger

Posted

I just installed a fresh oscommerce store and added CCGV trad and the same issues occurred - however I did note from the admin/server info that regsiter globals are set to : ON but this has never ever affected any functions of my demo sites in the past. Customers can create accounts, receive auto emails, etc etc... barring the issue I mentioned above that has appeared since installing CCGV trad, everything works.

 

Can anyone please tell me how important is the register globals ON/OFF issue actually is? If it is a matter of high significance then I'll ask the host to turn it off but is there any other way that it can be substitued by osC coding?

 

Looking forward to see if Fredrik says his register globals are ON or OFF - that'll clarify it slightly for me

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Posted

I just wanted to confirm that others has these issues too, or is it just me?

 

1, It gets wrong when a product is assigned to several categories. For example; I choosed category "Our favourites" as valid. The product I was added to cart and tried to redeem is in category "Our favourites" but it's "main category" is "skin care". It was added to "skin care" and then copied/linked to "Our Favourites" (not duplicated). When I choosed "Skin Care" as valid in coupon admin it worked... This is an issue I do not know how to solve. Also, there are no error messages like "The code you are trying to redeem are not valid for the products in your cart" (or something like that)

 

2, When leaving "Uses per coupon" and "Uses per coupon" blank it adds a 0 to those (both in admin and database). When editing a coupon it says "0".

 

3, CCGV doesnt add the right values in the report "Customer Orders-Total"? If its possible, please explain how to do this. Then I can also add it to contributions like Sales Report 2.

 

I figured out there were some old CCGV fields in the configuration table. I have removed all of them (got duplicates earlier) and added the 16 new ones. All other CCGV 5.14 related tables was deleted a long time ago though.

Posted
Looking forward to see if Fredrik says his register globals are ON or OFF - that'll clarify it slightly for me

 

Just had a look in Server Info, it says register_globals ON.

Posted

I also noticed "restrict_to_customers" in the Coupons table. This would have been a nice feature, will it ever be in use? :)

Posted
Okay, there are obviously some issues that some people are having. So before I try to deal with those issues there are some things I need to know please.

 

1. Which version of PHP is being used

2. Is Register Globals set to 'off' on your server

3. What version of MySQL is being used

4. Did you make sure to update to the latest version of MS2 (November 2005), because this contribution is based on the updated MS2 file set

5. If you had another version of CCGV installed did you completely delete that version - revert all modified files back to their originals, delete the database tables etc.

6. What other (if any) contributions do you have installed.

 

Please post your replies here and I'll take a look and see if I can replicate the problem. Just don't expect it to be done immediately!

 

Vger

 

Hi Vger, here is my setup

 

1. PHP 5.1.2

 

2. My test environment is on my local machine and I don't know how to check the register globals setting, any advice?

 

3. MySQL v4.1.18

 

4. This is a pretty new shop and was developed using the latest MS2 file set

 

5. No previous versions of CCGV

 

6. Bank Transfer, Condition of use agreement, Custom Search, Force Attribute, How did you hear 1.4, login_box best, Paypal Fee, register_globals 1.3, Header tags, Specials valid from, UK Royal Mail prices.

 

Hope this helps. Given that a refresh is all that is needed to get the coupon to show up it looks like it could (hopefully) be something pretty simple to fix. Let me know if there is anything I can test for you.

 

Ian

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...