Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Scrolling Best Sellers Box - photos won't center


Guest

Recommended Posts

I just installed the Scrolling Bestseller with Images contrib.

 

As you can see here at my site, the photos in the Best Seller Box won't center. What do I need to add to the best_sellers_scroll.php file to get these photos in the middle of the box? Here's the code:

 

<?php
/*
 $Id: best_sellers.php,v 1.21 2003/06/09 22:07:52 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License
*/

 if (isset($current_category_id) && ($current_category_id > 0)) {
$best_sellers_query = tep_db_query("select distinct p.products_id, p.products_image, pd.products_name from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c, " . TABLE_CATEGORIES . " c where p.products_status = '1' and p.products_ordered > 0 and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and p.products_id = p2c.products_id and p2c.categories_id = c.categories_id and '" . (int)$current_category_id . "' in (c.categories_id, c.parent_id) order by p.products_ordered desc, pd.products_name limit " . MAX_DISPLAY_BESTSELLERS);
 } else {
$best_sellers_query = tep_db_query("select distinct p.products_id, p.products_image, pd.products_name from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_ordered > 0 and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' order by p.products_ordered desc, pd.products_name limit " . MAX_DISPLAY_BESTSELLERS);
 }

 if (tep_db_num_rows($best_sellers_query) >= MIN_DISPLAY_BESTSELLERS) {
?>
<!-- best_sellers_scroll //-->
	  <tr>
		<td>
<?php
$info_box_contents = array();
$info_box_contents[] = array('text' => BOX_HEADING_BESTSELLERS);

new infoBoxHeading($info_box_contents, false, false);

$rows = 0;
$bestsellers_list = '<table border="0" width="100%" cellspacing="0" cellpadding="1">';
while ($best_sellers = tep_db_fetch_array($best_sellers_query)) {
  $rows++;
  $bestsellers_list .= '<tr><td class="infoBoxContents" valign="top">'  . '</td><td class="infoBoxContents">'. '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' .tep_image(DIR_WS_IMAGES . $best_sellers['products_image'], $best_sellers['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT).'<br>'. tep_row_number_format($rows). '. <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '</a></td></tr>';
}
$bestsellers_list .= '</table>';

$info_box_contents = array();
$info_box_contents[] = array('text' => '<MARQUEE behavior= "scroll" align= "center" direction= "up" height="160" scrollamount= "2" scrolldelay= "70" onmouseover=\'this.stop()\' onmouseout=\'this.start()\'>'.$bestsellers_list.'</MARQUEE>');

new infoBox($info_box_contents);
?>
		</td>
	  </tr>
<!-- best_sellers_scroll_eof //-->
<?php
 }
?>

 

Thanks for the help!

 

Andrea

Link to comment
Share on other sites

Change this line:

 

$bestsellers_list = '<table border="0" width="100%" cellspacing="0" cellpadding="1">';

 

to:

 

$bestsellers_list = '<table align="center" border="0" width="100%" cellspacing="0" cellpadding="1">';

 

That should fix it.

Link to comment
Share on other sites

Sorry, it should be this line:

 

$bestsellers_list .= '<tr><td class="infoBoxContents" valign="top">' . '</td>

 

change it to this:

 

$bestsellers_list .= '<tr><td class="infoBoxContents" align="center" valign="top">' . '</td>

Link to comment
Share on other sites

That's not fixing it, either.

 

Actually, I tried that earlier; but, took it out when I saw it didn't work.

 

I put it back after you suggested it, just to be sure, and...nope.

 

I'm now back to just the original file with none of the previous adjustments in place.

 

Are you stumped now? I am.

Link to comment
Share on other sites

Perhaps you could look at the file for What's New and find the answer?

 

I mean, the photos and text in that box are centered. Would it have something to do with the number sequence in Best Sellers? On that note, is there a way to get rid of the numbers, 1, 2, 3, etc. and just show a running list of Best Sellers with no ratings-number list?

Link to comment
Share on other sites

From your original code change this:

 

$info_box_contents[] = array('text' => '<MARQUEE behavior= "scroll" align= "center" direction= "up" height="160" scrollamount= "2" scrolldelay= "70" onmouseover=\'this.stop()\' onmouseout=\'this.start()\'>'.$bestsellers_list.'</MARQUEE>');

 

to this:

$info_box_contents[] = array('align' => 'center',
'text' => '<MARQUEE behavior= "scroll" align= "center" direction= "up" height="160" scrollamount= "2" scrolldelay= "70" onmouseover=\'this.stop()\' onmouseout=\'this.start()\'>'.$bestsellers_list.'</MARQUEE>');

Link to comment
Share on other sites

yea ok, you also need one other thing at the top of the previous change, I guess:

 

this code:

$bestsellers_list .= '<tr><td class="infoBoxContents" valign="top">' . '</td><td class="infoBoxContents">'. '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' .tep_image(DIR_WS_IMAGES . $best_sellers['products_image'], $best_sellers['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT).'<br>'. tep_row_number_format($rows). '. <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '</a></td></tr>';

 

change it to this:

$bestsellers_list .= '<tr><td class="infoBoxContents" valign="top">' . '</td><td class="infoBoxContents">'. '<center><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' .tep_image(DIR_WS_IMAGES . $best_sellers['products_image'], $best_sellers['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT).'</a></center><br>'. tep_row_number_format($rows). '. <center><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '</a></center></td></tr>';

 

should work its how I have it on my site.

 

PS I did a change closing the first <a> tag I think was left open on your original

Link to comment
Share on other sites

THANK YOU!!!!!!!! You're a genius!

 

If I may bother you some more, do you know how to get rid of the numbers of the items so they don't appear? Most everything I sell is one of a kind and there's no need for them to be seen onscreen in any numeric order, like, 1, 2, 3. For me, it's enough just to have the items there with their photos and links.

Link to comment
Share on other sites

  • 2 years later...

Hi.. I have tried this contribution.. Its not working for me..I am still a newbie.. Can anyone help me out? I want to have a scrolling bestseller on my site.

 

Thanks guys! :blush:

"I am not a Newbie but I am not an Expert either..."
"Lets learn about osCommerce together!..."
Link to comment
Share on other sites

ok remove this code:

 

. tep_row_number_format($rows). '.

 

notice there is an extra space at the end of that code.

 

Hi..where did everybody go?..Can anyone help me please? :rolleyes: :unsure: :(

"I am not a Newbie but I am not an Expert either..."
"Lets learn about osCommerce together!..."
Link to comment
Share on other sites

you should make your own post with the question.. you are not going to get answers on someone else's post.

A great place for newbies to start

Road Map to oscommerce File Structure

DO NOT PM ME FOR HELP. My time is valuable, unless i ask you to PM me, please dont. You will get better help if you post publicly. I am not as good at this as you think anyways!

 

HOWEVER, you can visit my blog (go to my profile to see it) and post a question there, i will find time to get back and answer you

 

Proud Memeber of the CODE BREAKERS CLUB!!

Link to comment
Share on other sites

you should make your own post with the question.. you are not going to get answers on someone else's post.

 

It's regarding about the same topic as the post starter..About scrolling best seller..

"I am not a Newbie but I am not an Expert either..."
"Lets learn about osCommerce together!..."
Link to comment
Share on other sites

Hi,

I have a different problem with this contribution, the product images look stretched and too wide compared to the rest of the small_image_height / width images

 

Any help?

 

	$rows = 0;
$bestsellers_list = '<table border="0" width="100%" cellspacing="0" cellpadding="1">';
while ($best_sellers = tep_db_fetch_array($best_sellers_query)) {
  $rows++;
  $bestsellers_list .= '<tr><td class="infoBoxContents" valign="top">'  . '</td><td class="infoBoxContents">' .tep_row_number_format($rows). ' - <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '<br>' . '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' .tep_image(DIR_WS_IMAGES . $best_sellers['products_image1'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></td></tr>';
}
$bestsellers_list .= '</table>';

$info_box_contents = array();
$info_box_contents[] = array('text' => '<MARQUEE behavior= "scroll" align= "center" direction= "up" height="160" scrollamount= "2" scrolldelay= "70" onmouseover=\'this.stop()\' onmouseout=\'this.start()\'>'.$bestsellers_list.'</MARQUEE>');

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...