yanling Posted February 17, 2006 Posted February 17, 2006 hey ,thanks everyone first. when I click my banner manager page I get "Banner Manager Banners Groups Displays / Clicks Status Action 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-20, 20' at line 1 select banners_id, banners_title, banners_image, banners_group, status, expires_date, expires_impressions, date_status_change, date_scheduled, date_added from banners order by banners_title, banners_group limit -20, 20 " and my code is as follows <?php /* $Id: banner.php,v 1.12 2003/06/20 00:12:59 hpdl Exp $ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright © 2003 osCommerce Released under the GNU General Public License */ //// // Sets the status of a banner function tep_set_banner_status($banners_id, $status) { if ($status == '1') { return tep_db_query("update " . TABLE_BANNERS . " set status = '1', date_status_change = now(), date_scheduled = NULL where banners_id = '" . (int)$banners_id . "'"); } elseif ($status == '0') { return tep_db_query("update " . TABLE_BANNERS . " set status = '0', date_status_change = now() where banners_id = '" . (int)$banners_id . "'"); } else { return -1; } } //// // Auto activate banners function tep_activate_banners() { $banners_query = tep_db_query("select banners_id, date_scheduled from " . TABLE_BANNERS . " where date_scheduled != ''"); if (tep_db_num_rows($banners_query)) { while ($banners = tep_db_fetch_array($banners_query)) { if (date('Y-m-d H:i:s') >= $banners['date_scheduled']) { tep_set_banner_status($banners['banners_id'], '1'); } } } } //// // Auto expire banners function tep_expire_banners() { $banners_query = tep_db_query("select b.banners_id, b.expires_date, b.expires_impressions, sum(bh.banners_shown) as banners_shown from " . TABLE_BANNERS . " b, " . TABLE_BANNERS_HISTORY . " bh where b.status = '1' and b.banners_id = bh.banners_id group by b.banners_id"); if (tep_db_num_rows($banners_query)) { while ($banners = tep_db_fetch_array($banners_query)) { if (tep_not_null($banners['expires_date'])) { if (date('Y-m-d H:i:s') >= $banners['expires_date']) { tep_set_banner_status($banners['banners_id'], '0'); } } elseif (tep_not_null($banners['expires_impressions'])) { if ( ($banners['expires_impressions'] > 0) && ($banners['banners_shown'] >= $banners['expires_impressions']) ) { tep_set_banner_status($banners['banners_id'], '0'); } } } } } //// // Display a banner from the specified group or banner id ($identifier) function tep_display_banner($action, $identifier) { if ($action == 'dynamic') { $banners_query = tep_db_query("select count(*) as count from " . TABLE_BANNERS . " where status = '1' and banners_group = '" . $identifier . "'"); $banners = tep_db_fetch_array($banners_query); if ($banners['count'] > 0) { $banner = tep_random_select("select banners_id, banners_title, banners_image, banners_html_text from " . TABLE_BANNERS . " where status = '1' and banners_group = '" . $identifier . "'"); } else { return '<b>TEP ERROR! (tep_display_banner(' . $action . ', ' . $identifier . ') -> No banners with group '' . $identifier . '' found!</b>'; } } elseif ($action == 'static') { if (is_array($identifier)) { $banner = $identifier; } else { $banner_query = tep_db_query("select banners_id, banners_title, banners_image, banners_html_text from " . TABLE_BANNERS . " where status = '1' and banners_id = '" . (int)$identifier . "'"); if (tep_db_num_rows($banner_query)) { $banner = tep_db_fetch_array($banner_query); } else { return '<b>TEP ERROR! (tep_display_banner(' . $action . ', ' . $identifier . ') -> Banner with ID '' . $identifier . '' not found, or status inactive</b>'; } } } else { return '<b>TEP ERROR! (tep_display_banner(' . $action . ', ' . $identifier . ') -> Unknown $action parameter value - it must be either 'dynamic' or 'static'</b>'; } if (tep_not_null($banner['banners_html_text'])) { $banner_string = $banner['banners_html_text']; } else { $banner_string = '<a href="' . tep_href_link(FILENAME_REDIRECT, 'action=banner&goto=' . $banner['banners_id']) . '" target="_blank">' . tep_image(DIR_WS_IMAGES . $banner['banners_image'], $banner['banners_title']) . '</a>'; } tep_update_banner_display_count($banner['banners_id']); return $banner_string; } //// // Check to see if a banner exists function tep_banner_exists($action, $identifier) { if ($action == 'dynamic') { return tep_random_select("select banners_id, banners_title, banners_image, banners_html_text from " . TABLE_BANNERS . " where status = '1' and banners_group = '" . $identifier . "'"); } elseif ($action == 'static') { $banner_query = tep_db_query("select banners_id, banners_title, banners_image, banners_html_text from " . TABLE_BANNERS . " where status = '1' and banners_id = '" . (int)$identifier . "'"); return tep_db_fetch_array($banner_query); } else { return false; } } //// // Update the banner display statistics function tep_update_banner_display_count($banner_id) { $banner_check_query = tep_db_query("select count(*) as count from " . TABLE_BANNERS_HISTORY . " where banners_id = '" . (int)$banner_id . "' and date_format(banners_history_date, '%Y%m%d') = date_format(now(), '%Y%m%d')"); $banner_check = tep_db_fetch_array($banner_check_query); if ($banner_check['count'] > 0) { tep_db_query("update " . TABLE_BANNERS_HISTORY . " set banners_shown = banners_shown + 1 where banners_id = '" . (int)$banner_id . "' and date_format(banners_history_date, '%Y%m%d') = date_format(now(), '%Y%m%d')"); } else { tep_db_query("insert into " . TABLE_BANNERS_HISTORY . " (banners_id, banners_shown, banners_history_date) values ('" . (int)$banner_id . "', 1, now())"); } } //// // Update the banner click statistics function tep_update_banner_click_count($banner_id) { tep_db_query("update " . TABLE_BANNERS_HISTORY . " set banners_clicked = banners_clicked + 1 where banners_id = '" . (int)$banner_id . "' and date_format(banners_history_date, '%Y%m%d') = date_format(now(), '%Y%m%d')"); } ?> any ideas ,any suggestions for me ? many appreciate thanks a lot yanling
Jack_mcs Posted February 17, 2006 Posted February 17, 2006 It's a php compatibility problem. There is a specific fix in the knowledge base or, better still, just install the security update, which has it, as well as other fixes, in it. Jack Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons
yanling Posted February 17, 2006 Author Posted February 17, 2006 It's a php compatibility problem. There is a specific fix in the knowledge base or, better still, just install the security update, which has it, as well as other fixes, in it. Jack thanks a lot
Recommended Posts
Archived
This topic is now archived and is closed to further replies.