<H1> Headings

[cd100]

Hi,

Can anyone tell me how to add <H1> Heading tags to my page?

Have managed to do it manually to the index page, but can't suss out what to do elsewhere.

 

Found this earlier, but it didn't seem to work.

 

product_info.php, line 93:

 

Change this:

CODE

 

<td class="pageHeading" valign="top"><?php echo $products_name; ?></td>

 

To this:

CODE

 

<td valign="top"><h1><?php echo $products_name; ?></h1></td>

 

Any help appreciated,

Claire

[Guest]

Can you explain what doesn't work?

 

once you change the products_info.php with this

<td valign="top"><h1><?php echo $products_name; ?></h1></td>

 

should take effect. Unless you override the h1 tag in your stylesheet.css file.

[cd100]

Hi,

Well, on my index page, the heading is larger (as I presume an H1 heading should be) . I added the tags to the index page manually though.

The Headings on my category and product page is the same size as it always was. I am not home till later, so cannot check my stylesheet, but would the index page work if there was a problem with the stylesheet?

Regards,

Claire

[Guest]

ok, you can see from the html source generated if the h1 tags are appended to the products name.

[cd100]

ok, you can see from the html source generated if the h1 tags are appended to the products name.

 

Err,

Now I'm lost.

Regards,

Claire

[Guest]

Err,

Now I'm lost.

 

go with your browser to your shop in the page where there is a products description. Then click view->source on the browser you will see the text for the html code in the notepad or some editor there. You can then search for <h1> see if it is present next to the products title. At least you will know if the code you changed takes effect.

[cd100]

go with your browser to your shop in the page where there is a products description. Then click view->source on the browser you will see the text for the html code in the notepad or some editor there. You can then search for <h1> see if it is present next to the products title. At least you will know if the code you changed takes effect.

 

Have done that, and it is not there (i.e. no h1 is being found)

I have this code at the bottom of my stylesheet. * input requirement */

 

.inputRequirement { font-family: Verdana, Arial, sans-serif; font-size: 10px; color: #ff0000; }

h1 {

font-family: Verdana, Arial, sans-serif;

font-size: 20px;

font-weight: bold;

}

 

h2 {

font-family: Verdana, Arial, sans-serif;

font-size: 14px;

}

 

Is it anything at all to do with it, or am I just (as I suspect!)

clutching at straws.

Regards,

Claire

[Guest]

well couple of things.

 

- Post the product_info.php file (the one you modified)

- Is there a url to see the problem?

[cd100]

well couple of things.

 

- Post the product_info.php file (the one you modified)

- Is there a url to see the problem?

 

 

O.k here it is:

 

<?php

/*

$Id: product_info.php,v 1.97 2003/07/01 14:34:54 hpdl Exp $

 

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

 

Copyright © 2003 osCommerce

 

Released under the GNU General Public License

*/

 

require('includes/application_top.php');

//begin seo_metatags

$seo_info_query = tep_db_query("select pd.language_id, p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id,

p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "'" . " and pd.language_id ='" . (int)$languages_id . "'");

$seo_product_info = tep_db_fetch_array($seo_info_query);

$seo_product_name = strip_tags ($seo_product_info['products_name'], "");

$seo_product_description = strip_tags ($seo_product_info['products_description'], "");

$seo_product_model = strip_tags ($seo_product_info['products_model'], "");

 

$seo_manufacturer_query = tep_db_query("select m.manufacturers_id, m.manufacturers_name from " . TABLE_MANUFACTURERS . " m left join " . TABLE_MANUFACTURERS_INFO . " mi on (m.manufacturers_id = mi.manufacturers_id and mi.languages_id = '" . (int)$languages_id . "'), " . TABLE_PRODUCTS . " p where p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and p.manufacturers_id = m.manufacturers_id");

$seo_manufacturers = tep_db_fetch_array($seo_manufacturer_query);

$seo_manufacturer_name = strip_tags ($seo_manufacturers['manufacturers_name'], "");

$page_title = $seo_product_name;

// end seo_metatags

 

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

 

$product_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_check = tep_db_fetch_array($product_check_query);

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<html <?php echo HTML_PARAMS; ?>>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">

<title><?php echo $page_title; ?></title>

<meta name="keywords" content="<?php echo $page_title; ?><?php if ($seo_product_model){echo ', ' . $seo_product_model;} ?>, <?php echo $seo_manufacturer_name; ?>">

<meta name="description" content="<?php echo $seo_product_name . ', ' . $seo_manufacturer_name . ' , ' . strip_tags(TITLE, ""); ?>">

<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">

<link rel="stylesheet" type="text/css" href="stylesheet.css">

<script language="javascript"><!--

function popupWindow(url) {

window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,res

izable=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,le

ft=150')

}

//--></script>

</head>

<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">

<!-- header //-->

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<!-- header_eof //-->

 

<!-- body //-->

<table border="0" width="100%" cellspacing="3" cellpadding="3">

<tr>

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<!-- left_navigation //-->

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

<!-- left_navigation_eof //-->

</table></td>

<!-- body_text //-->

<td width="100%" valign="top"><?php echo tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')) . 'action=add_product')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

<?php

if ($product_check['total'] < 1) {

?>

<tr>

<td><?php new infoBox(array(array('text' => TEXT_PRODUCT_NOT_FOUND))); ?></td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<tr>

<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">

<tr class="infoBoxContents">

<td><table border="0" width="100%" cellspacing="0" cellpadding="2">

<tr>

<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>

<td align="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>

<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<?php

} else {

$product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_info = tep_db_fetch_array($product_info_query);

 

tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

 

if ($new_price = tep_get_products_special_price($product_info['products_id'])) {

$products_price = '<s>' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';

} else {

$products_price = $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));

}

 

if (tep_not_null($product_info['products_model'])) {

$products_name = $product_info['products_name'] . '<br><span class="smallText">[' . $product_info['products_model'] . ']</span>';

} else {

$products_name = $product_info['products_name'];

}

?>

<tr>

<td><table border="0" width="100%" cellspacing="0" cellpadding="0">

<tr>

<td valign="top"><h1><?php echo $products_name; ?></h1></td>

<td class="pageHeading" align="right" valign="top"><?php echo $products_price; ?></td>

</tr>

</table></td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<tr>

<td class="main">

<?php

if (tep_not_null($product_info['products_image'])) {

?>

<table border="0" cellspacing="0" cellpadding="2" align="right">

<tr>

<td align="center" class="smallText">

<script language="javascript"><!--

document.write('<?php echo '<a href="java script:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '\\\')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

</td>

</tr>

</table>

<?php

}

?>

<p><?php echo stripslashes($product_info['products_description']); ?></p>

<?php

$products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "'");

$products_attributes = tep_db_fetch_array($products_attributes_query);

if ($products_attributes['total'] > 0) {

?>

<table border="0" cellspacing="0" cellpadding="2">

<tr>

<td class="main" colspan="2"><?php echo TEXT_PRODUCT_OPTIONS; ?></td>

</tr>

<?php

$products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "' order by popt.products_options_name");

while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {

$products_options_array = array();

$products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'");

while ($products_options = tep_db_fetch_array($products_options_query)) {

$products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);

if ($products_options['options_values_price'] != '0') {

$products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';

}

}

 

if (isset($cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']])) {

$selected_attribute = $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']];

} else {

$selected_attribute = false;

}

?>

<tr>

<td class="main"><?php echo $products_options_name['products_options_name'] . ':'; ?></td>

<td class="main"><?php echo tep_draw_pull_down_menu('id[' . $products_options_name['products_options_id'] . ']', $products_options_array, $selected_attribute); ?></td>

</tr>

<?php

}

?>

</table>

<?php

}

?>

</td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<?php

$reviews_query = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "'");

$reviews = tep_db_fetch_array($reviews_query);

if ($reviews['count'] > 0) {

?>

<tr>

<td class="main"><?php echo TEXT_CURRENT_REVIEWS . ' ' . $reviews['count']; ?></td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<?php

}

 

if (tep_not_null($product_info['products_url'])) {

?>

<tr>

<td class="main"><?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?></td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<?php

}

 

if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {

?>

<tr>

<td align="center" class="smallText"><?php echo sprintf(TEXT_DATE_AVAILABLE, tep_date_long($product_info['products_date_available'])); ?></td>

</tr>

<?php

} else {

?>

<tr>

<td align="center" class="smallText"><?php echo sprintf(TEXT_DATE_ADDED, tep_date_long($product_info['products_date_added'])); ?></td>

</tr>

<?php

}

?>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<tr>

<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">

<tr class="infoBoxContents">

<td><table border="0" width="100%" cellspacing="0" cellpadding="2">

<tr>

<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>

<td class="main"><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>

<td class="main" align="right"><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('button_in_cart.gif', IMAGE_BUTTON_IN_CART); ?></td>

<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<tr>

<td>

<?php

if ((USE_CACHE == 'true') && empty($SID)) {

echo tep_cache_also_purchased(3600);

} else {

include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);

}

}

?>

</td>

</tr>

</table></form></td>

<!-- body_text_eof //-->

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<!-- right_navigation //-->

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

<!-- right_navigation_eof //-->

</table></td>

</tr>

</table>

<!-- body_eof //-->

 

<!-- footer //-->

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

<!-- footer_eof //-->

<br>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

[Guest]

that looks correct, I tried it on my store (the h1 tags) and works so double check you have the file updated in your store.

[cd100]

Hi,

The file that I posted was ftp'd from my store, so it is definitely the one being used. (That is what you mean, right?)

Regards,

Claire

[Guest]

ok is there a url for your store so I can see?

[cd100]

Hi,

Yes there is, but its another adult site, so only go there if you're thick skinned!

 

www.webdreaming.co.uk

 

The other way that I can tell it's not working properly, is that I get this message from my optimization software on a product page, and I don't get it when I analyze my index page.

 

1. Your page either has no <H1> headings, or has no text in the first heading on the page! It is really important that you put your keyword in one of these headings. We also recommend that you put an <H1> heading as close to the beginning of your page as possible. The search engines traditionally consider the text in the headings essential, and having your keyword there will positively influence your website overall optimality

[Wendy James]

The H1 tag is not showing up when you view source, it still shows the pagheading class.

 

Not sure why that would be if you are certain you uploaded the changed file to the right place.

[cd100]

Hi,

O.k then, so lets just check that.

That file was

 

/public_html/product_info.php

 

Is that correct?

 

Regards

Claire

[Guest]

well ok from the source I see there is no h1 tag and the only thing I can say is the file change is not on the server. Well lets try this, find this code in that file:

 

if (tep_not_null($product_info['products_model'])) {
$products_name = $product_info['products_name'] . '<br><span class="smallText">[' . $product_info['products_model'] . ']</span>';
} else {
$products_name = $product_info['products_name'];
}

 

right below it add this line

$products_name = '<h1>' . $products_name . '</h1>';

[cd100]

Ok,

Have done that, and uploaded the file

[Guest]

ok still not there, so search your tree how many product_info.php files you have on the server? You should modify the one in the root of your store. seems like there is another file.

[cd100]

ok still not there, so search your tree how many product_info.php files you have on the server? You should modify the one in the root of your store. seems like there is another file.

 

 

/public_html/product_info.php

 

 

This is the one I'm playing with...is that right?

[Guest]

is there a

/product_info.php

 

or

 

/catalog/product_info.php

 

file? I cannot see from here because you have the seo urls active and redirection so no matter what link I put for a product it goes to it. You could check from the root of your ftp the directories. I have no way of seeing this here.

[cd100]

Hi,

osc is installed in my root directory.

 

The file I am editing is public_html/product_info.php i.e. it is in the same place as my admin folder, my includes folder, and lots of other .php files (account.php, conditions.php, download.php, to name but a few)

 

The only other file with this name is in my languages/english folder, and it's completely different.

 

Regards,

Claire

[Guest]

I get errors now when I go to the products description pages. What did you change?

[cd100]

Aaarrgggh!!

Sorry, was messing about overwriting each file with an original, to see if I could pinpoint problem.

All back to normal now, but still not working! (H1 tags, I mean)

Thanks for all your help, and if you have any ideas, please post them and I will have a look tomorrow. It's way past my bedtime here, and I just have not got the stamina to have another 3.30 am finish (like I have for the past 3 nights)

Again, thanks for your time, you've been very patient!

Regards,

Claire

[cd100]

Hello.

Still no luck.

It seems to me that there is something else preventing this code from taking effect, but I am no expert.

I have checked that I am editing the right file, and it is definitely on my server, so I can't see what else could be the problem?

Can anybody else try and shed some light? The only thing I can think of doing is to replace each file in my store with the original file (one by one of course), and see if I can get it working that way.

Could anyone suggest where I might start? i.e. with which files.

I presume, probably wrongly, that nothing on the admin side of things would interfere with this, so should I just start with all the files in my root folder?

 

Regards,

Claire

[kgt]

I cannot go to your site right now, as I am at work. However, enigma1 mentioned you have seo urls. Which contribution did you install? This contribution combines index.php and product_info.php:

 

http://www.oscommerce.com/community/contributions,2796

 

If this is your contribution, you will need to edit index.php. Otherwise, I have not a clue.