Credit Class/Gift Vouchers/Discount Coupons 5.10

PopTheTop · May 2, 2005

But it should still be updated, shouldn't it?

audioeq · May 2, 2005

Yes, it should. But it doesnt solve the other problem.

May 2, 2005

In the order_total.php 5.13 changes there is:

if (!tep_session_is_registered($post_var)) tep_session_register($post_var);
    	 // START modification for Credit Class v5.13 by Rigadin: have to register the new created variable as global cause we are in a function
    	 $post_var = $HTTP_POST_VARS[$post_var]; // Rigadin: does not work because not global variable
    	 // END modification v5.13
     }

Apart from the comments, I can't see any difference with 5.12 - am I missing something subtle?

<{POST_SNAPBACK}>

Oops, I made first a modification at this place but found an easier fix later and put back the original v5.12 code but forgot to remove the old comments. => No changes made from v5.12

- Rigadin

harry216 · May 2, 2005

Hello,

i have installed ccgv 5.13 and have a little problem.

in the checkout_confirmation.php is an error. why will the money that will be taken off from the discount coupon (-4,71 euro) in the tax considered.

wrong.....

Zwischensumme: 58.05EUR

GLS (Versand nach DE : 1.45 kg): 4.90EUR

Gutscheine:5d878f: -4.71EUR <----- money from Discount Coupon that will be considered in tax

Summe: 58.24EUR

16%: 8.69EUR <-------

correctly

Zwischensumme: 58.05EUR

GLS (Versand nach DE : 1.45 kg): 4.90EUR

Gutscheine:5d878f: -4.71EUR

Summe: 58.24EUR

16%: 8.03EUR <-------

what must i do to correct this..???

thanks and sorry for my bad english

Harry

Tanaka · May 2, 2005

I have 2 places that this code is at in this file, do I replace both or just one of them?

<{POST_SNAPBACK}>

Hello,

This modification is ONLY for the code around line 196. This is because it effects the functionality of the percentage discount. The fixed discount is not effected by this bug (as far as I can tell).

If you are wondering what it should look like in the end, after all the bug fixes I submitted, look at the contribution homepage. I uploaded my updated ot_coupon.php file there.

If you have questions, I'll get back to you faster if you e-mail me (I don't check the boards very often).

Regards,

Joseph

Irin · May 2, 2005

Hello,

I have CCGV v5.11 installed in my osc. I use it more with Coupon Discounts. Everything works fine except when a Guest (via Quick Checkout) enters a coupon number at checkout, it's not substracted from the total amount. Although, if registered user enters the same coupon number, it works perfect.

My question is why it doesn't work with Guest Account? What can be wrong?

Is anybody have a similar problem?

Thanks.

Irina.

PopTheTop · May 3, 2005

Hello,
This modification is ONLY for the code around line 196. This is because it effects the functionality of the percentage discount. The fixed discount is not effected by this bug (as far as I can tell).

If you are wondering what it should look like in the end, after all the bug fixes I submitted, look at the contribution homepage. I uploaded my updated ot_coupon.php file there.

If you have questions, I'll get back to you faster if you e-mail me (I don't check the boards very often).

Regards,

Joseph

<{POST_SNAPBACK}>

Well, my line numbers are lower than that. The 1st one is line number 155 and the other is 179 (see below). Which one should I replace?

 	 if ($get_result['coupon_minimum_order'] <= $this->get_order_total()) {
   if ($get_result['restrict_to_products'] || $get_result['restrict_to_categories']) {
  	 for ($i=0; $i<sizeof($order->products); $i++) {
     if ($get_result['restrict_to_products']) {
    	 $pr_ids = split("[,]", $get_result['restrict_to_products']);
    	 for ($ii = 0; $ii < count($pr_ids); $ii++) {
       if ($pr_ids[$ii] == tep_get_prid($order->products[$i]['id'])) {
      	 if ($get_result['coupon_type'] == 'P') {
        	 $pr_c = $this->product_price($pr_ids[$ii]); //Fred 2003-10-28, fix for the row above, otherwise the discount is calc based on price excl VAT!
        	 $pod_amount = round($pr_c*10)/10*$c_deduct/100;
        	 $od_amount = $od_amount + $pod_amount;
         } else {
        	 $od_amount = $c_deduct;
         }
      	 }
       }
    	 } else {
       $cat_ids = split("[,]", $get_result['restrict_to_categories']);
       for ($i=0; $i<sizeof($order->products); $i++) {
      	 $my_path = tep_get_product_path(tep_get_prid($order->products[$i]['id']));
      	 $sub_cat_ids = split("[_]", $my_path);
      	 for ($iii = 0; $iii < count($sub_cat_ids); $iii++) {
         for ($ii = 0; $ii < count($cat_ids); $ii++) {
        	 if ($sub_cat_ids[$iii] == $cat_ids[$ii]) {
           if ($get_result['coupon_type'] == 'P') {
          	 $pr_c = $this->product_price(tep_get_prid($order->products[$i]['id'])); //Fred 2003-10-28, fix for the row above, otherwise the discount is calc based on price excl VAT!
          	 $pod_amount = round($pr_c*10)/10*$c_deduct/100;
          	 $od_amount = $od_amount + $pod_amount;
           } else {
          	 $od_amount = $c_deduct;
           }
        	 }
         }
      	 }
       }
    	 }
     }
  	 } else {
     if ($get_result['coupon_type'] !='P') {
    	 $od_amount = $c_deduct;
     } else {
    	 $od_amount = $amount * $get_result['coupon_amount'] / 100;
     }
  	 }
   }
	 }

rose3694 · May 3, 2005

I'm getting the following error in the admin area for the coupon thing.

1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-20, 20' at line 1

select coupon_id, coupon_code, coupon_amount, coupon_type, coupon_start_date,coupon_expire_date,uses_per_user,uses_per_coupon,restrict_to_p

roducts, restrict_to_categories, date_created,date_modified from coupons where coupon_active='Y' and coupon_type != 'G' limit -20, 20

What do I need to do to fix it, everything looks just like my other store I have setup and working fine.

Thanks,

Carol

PopTheTop · May 3, 2005

You need to post that line of code...

select coupon_id, coupon_code, coupon_amount, coupon_type, coupon_start_date,coupon_expire_date,uses_per_user,uses_per_coupon,restrict_to_p

roducts, restrict_to_categories, date_created,date_modified from coupons where coupon_active='Y' and coupon_type != 'G' limit -20, 20

rose3694 · May 3, 2005

You need to post that line of code...

select coupon_id, coupon_code, coupon_amount, coupon_type, coupon_start_date,coupon_expire_date,uses_per_user,uses_per_coupon,restrict_to_p

roducts, restrict_to_categories, date_created,date_modified from coupons where coupon_active='Y' and coupon_type != 'G' limit -20, 20

<{POST_SNAPBACK}>

I'm not to sure what you are trying to tell me, here is a screen shot if maybe I'm not being clear.

I had everything upload where it should have and did everything just like I did with my store so I don't see why I'm having a problem.

AmethystHaze · May 3, 2005

Hi I'm having a problem with the discount voucher.

I have:

1. enabled the mod in admin

2. created a coupon

Now:

I checkout using a coupon code and click the Redeem button, the checkout_confirmation page shows no indication of any discount what-so-ever.

Addt'l Notes:

- Tried some fake codes and it caught the fake codes, the real code goes through, but does not show in conf. page payment calculations

Disclaimer:

- I ran a quick search in this thread and couldn't find any reference to my problem

- Read through install.html and couldn't find anything that I missed

Please help and thank you.

AmethystHaze · May 3, 2005

Absolutely NEVERMIND my previous post. ((FALSE ALARM))

/apologizes

Deskdirect · May 3, 2005

I'm not to sure what you are trying to tell me, here is a screen shot if maybe I'm not being clear.

I had everything upload where it should have and did everything just like I did with my store so I don't see why I'm having a problem.

<{POST_SNAPBACK}>

I am getting the same error when trying to view Gift Voucher Queue,

Mail Gift Voucher, and Gift Vouchers sent.

Someone please help!

firbest · May 3, 2005

hi

I got a error message Fatal error: Call to undefined function: clear_posts() in /homepages/42/d125170818/htdocs/checkout_payment.php on line 75

this happens when i go to the checkout and then pressing continue the error occours.

The checkout_payment.php file contains info :

<?php

/*

$Id: checkout_payment.php,v 1.2.7 2004/01/01 12:03:27 Strider Exp $

$Id: checkout_payment.php,v 1.113 2003/07/24 23:03:27 Strider Exp $

$Id: checkout_payment.php,v 1.113 2003/06/29 23:03:27 hpdl Exp $

$Id: checkout_payment.php,v 1.6.2.3 2003/05/10 20:12:14 wilt Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

// if the customer is not logged on, redirect them to the login page

if (!tep_session_is_registered('customer_id')) {

$navigation->set_snapshot();

tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL'));

}

// if there is nothing in the customers cart, redirect them to the shopping cart page

if ($cart->count_contents() < 1) {

tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));

}

// if no shipping method has been selected, redirect the customer to the shipping method selection page

if (!tep_session_is_registered('shipping')) {

tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

}

// avoid hack attempts during the checkout procedure by checking the internal cartID

if (isset($cart->cartID) && tep_session_is_registered('cartID')) {

if ($cart->cartID != $cartID) {

tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

}

// if we have been here before and are coming back get rid of the credit covers variable

if(tep_session_is_registered('credit_covers')) tep_session_unregister('credit_covers'); //ICW ADDED FOR CREDIT CLASS SYSTEM

// Stock Check

if ( (STOCK_CHECK == 'true') && (STOCK_ALLOW_CHECKOUT != 'true') ) {

$products = $cart->get_products();

for ($i=0, $n=sizeof($products); $i<$n; $i++) {

if (tep_check_stock($products[$i]['id'], $products[$i]['quantity'])) {

tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));

break;

}

// if no billing destination address was selected, use the customers own address as default

if (!tep_session_is_registered('billto')) {

tep_session_register('billto');

$billto = $customer_default_address_id;

} else {

// verify the selected billing address

$check_address_query = tep_db_query("select count(*) as total from " . TABLE_ADDRESS_BOOK . " where customers_id = '" . (int)$customer_id . "' and address_book_id = '" . (int)$billto . "'");

$check_address = tep_db_fetch_array($check_address_query);

if ($check_address['total'] != '1') {

$billto = $customer_default_address_id;

if (tep_session_is_registered('payment')) tep_session_unregister('payment');

}

require(DIR_WS_CLASSES . 'order.php');

$order = new order;

require(DIR_WS_CLASSES . 'order_total.php');//ICW ADDED FOR CREDIT CLASS SYSTEM

$order_total_modules = new order_total;//ICW ADDED FOR CREDIT CLASS SYSTEM

$order_total_modules->clear_posts(); // ADDED FOR CREDIT CLASS SYSTEM by Rigadin in v5.13

if (!tep_session_is_registered('comments')) tep_session_register('comments');

$total_weight = $cart->show_weight();

$total_count = $cart->count_contents();

$total_count = $cart->count_contents_virtual(); //ICW ADDED FOR CREDIT CLASS SYSTEM

// load all enabled payment modules

require(DIR_WS_CLASSES . 'payment.php');

$payment_modules = new payment;

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CHECKOUT_PAYMENT);

$breadcrumb->add(NAVBAR_TITLE_1, tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

$breadcrumb->add(NAVBAR_TITLE_2, tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'));

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

var selected;

<?php// following jscript function ICW ADDED FOR CREDIT CLASS SYSTEM ?>

var submitter = null;

function submitFunction() {

submitter = 1;

}

<?php// END OF ICW ADDED FOR ORDER_TOTAL CREDIT SYSTEM ?>

function selectRowEffect(object, buttonSelect) {

if (!selected) {

if (document.getElementById) {

selected = document.getElementById('defaultSelected');

} else {

selected = document.all['defaultSelected'];

}

if (selected) selected.className = 'moduleRow';

object.className = 'moduleRowSelected';

selected = object;

// one button is not an array

if (document.checkout_payment.payment[0]) {

document.checkout_payment.payment[buttonSelect].checked=true;

} else {

document.checkout_payment.payment.checked=true;

}

function rowOverEffect(object) {

if (object.className == 'moduleRow') object.className = 'moduleRowOver';

}

function rowOutEffect(object) {

if (object.className == 'moduleRowOver') object.className = 'moduleRow';

}

//--></script>

<?php echo $payment_modules->javascript_validation(); ?>

</head>

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<tr>

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</table></td>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

</tr>

<?php

if (isset($HTTP_GET_VARS['payment_error']) && is_object(${$HTTP_GET_VARS['payment_error']}) && ($error = ${$HTTP_GET_VARS['payment_error']}->get_error())) {

?>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

<tr>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<?php

}

?>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

<tr>

<td class="main" width="50%" valign="top"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?><br><br><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_PAYMENT_ADDRESS, '', 'SSL') . '">' . tep_image_button('button_change_address.gif', IMAGE_BUTTON_CHANGE_ADDRESS) . '</a>'; ?></td>

<tr>

</tr>

</table></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

<?php

$selection = $payment_modules->selection();

if (sizeof($selection) > 1) {

?>

<tr>

</tr>

<?php

} else {

?>

<tr>

</tr>

<?php

}

$radio_buttons = 0;

for ($i=0, $n=sizeof($selection); $i<$n; $i++) {

?>

<tr>

<?php

if ( ($selection[$i]['id'] == $payment) || ($n == 1) ) {

echo ' <tr id="defaultSelected" class="moduleRowSelected" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";

} else {

echo ' <tr class="moduleRow" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";

}

?>

<?php

if (sizeof($selection) > 1) {

echo tep_draw_radio_field('payment', $selection[$i]['id']);

} else {

echo tep_draw_hidden_field('payment', $selection[$i]['id']);

}

?>

</td>

</tr>

<?php

if (isset($selection[$i]['error'])) {

?>

<tr>

</tr>

<?php

} elseif (isset($selection[$i]['fields']) && is_array($selection[$i]['fields'])) {

?>

<tr>

<?php

for ($j=0, $n2=sizeof($selection[$i]['fields']); $j<$n2; $j++) {

?>

<tr>

</tr>

<?php

}

?>

</table></td>

</tr>

<?php

}

?>

</table></td>

</tr>

<?php

$radio_buttons++;

}

?>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<?php

echo $order_total_modules->credit_selection();//ICW ADDED FOR CREDIT CLASS SYSTEM

?>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

<tr>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><b><?php echo TITLE_CONTINUE_CHECKOUT_PROCEDURE . '</b><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

<tr>

</tr>

</table></td>

<tr>

</tr>

</table></td>

<tr>

</tr>

</table></td>

</tr>

<tr>

<td align="center" width="25%" class="checkoutBarFrom"><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL') . '" class="checkoutBarFrom">' . CHECKOUT_BAR_DELIVERY . '</a>'; ?></td>

</tr>

</table></td>

</tr>

</table></form></td>

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

</table></td>

</tr>

</table>

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

<br>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

jonyo · May 5, 2005

hi

I got a error message Fatal error: Call to undefined function: clear_posts() in /homepages/42/d125170818/htdocs/checkout_payment.php on line 75

this happens when i go to the checkout and then pressing continue the error occours.

The checkout_payment.php file contains info :

......

<{POST_SNAPBACK}>

Some friendly posting helpers:

Please do not double post

Also, please use the

code tags

for code, especially when it is so much code. I can't tell where the code starts and the message stops... It makes it much easier to understand your post.

1. make sure the function clearposts is defined.

2. make sure the file it is defined in is being included or required somewhere.

You can do this with any code editor that has the ability to search through multiple files for text, or if you are on a nix box use grep. Hope this helps some.

Sorry I have not been around in a while, been busy with finals...

unai · May 6, 2005

I'm not to sure what you are trying to tell me, here is a screen shot if maybe I'm not being clear.

I had everything upload where it should have and did everything just like I did with my store so I don't see why I'm having a problem.

<{POST_SNAPBACK}>

Hi everyone,

this is a known bug, and luckily for us it is also prtty easy to sort out.

chech out -20 +20 bug

regards,

unai

leitel · May 6, 2005

Installed Credit / Voucher to latest version of OSC. Everything works except...

When verifying Discount Coupon.. checkout_confirmation shows correct adjusted total (discount is redemed). But....... when it proceed to PayPal, the discount coupon is NOT reflected.

What have I done.

I traced through and verified that the adjusted total is correctly appearing in order->info total.

Although the confirmation page shows discount AND hidden values passed to PayPal reflect correct values INCLUDING amount equal to the adjusted total, PAYPAL ignores and shows the total WITHOUT the discount.

Is there somewhere I can look? Is there a patch? Is anyone else experiencing this?

Thanks! :)

firbest · May 6, 2005

Hi i have the following error

"Fatal error: Call to undefined function: clear_posts() in /homepages/42/d125170818/htdocs/checkout_payment.php on line 75"

Please let me know how to solve this error. I have been here all day on oscommerce please help to fix it as i have tried my best but i can't fix it.

Steel · May 8, 2005

I am try to make the box that says "tick here to use Gift voucher balance" default to checked. I did this for the newsletter in createaccount but the same coding is not working for checking the gift voucher redeem box

Any suggestions?

Steel

chrisr63 · May 8, 2005

Hi,

Apologies if this has been answered before but I have been through most of the threadwithout finding an answer.

I am about to launch a store and would like to offer past eBay customers a % discount on their first purchase. Is there a way of uploading all of the e-mail addresses in one go and then sending a bulk mail, rather than generating a separate e-mail for each person?

Thanks

May 9, 2005

Hi,

Apologies if this has been answered before but I have been through most of the threadwithout finding an answer.

I am about to launch a store and would like to offer past eBay customers a % discount on their first purchase. Is there a way of uploading all of the e-mail addresses in one go and then sending a bulk mail, rather than generating a separate e-mail for each person?

Thanks

<{POST_SNAPBACK}>

I'm interested in this too. Help!

May 9, 2005

I am try to make the box that says "tick here to use Gift voucher balance" default to checked. I did this for the newsletter in createaccount but the same coding is not working for checking the gift voucher redeem box
Any suggestions?

Steel

<{POST_SNAPBACK}>

open ot_gv module, find the ot_gv function and at the nearly end of the function you have to change:

$this->checkbox = $this->user_prompt . '<input type="checkbox" onClick="submitFunction()" name="' . 'c' . $this->code . '">';

to this:

$this->checkbox = $this->user_prompt . '<input type="checkbox" CHECKED onClick="submitFunction()" name="' . 'c' . $this->code . '">';

- Rigadin

coolthings.com.au · May 10, 2005

I have the same problem, I've found that sometimes the discount goes through and sometimes it doesn't.

The discount shows on the order_confirmation page but after you confirm the order it vanishes.

This is using the standard Money Order & credit card payment modules.

PopTheTop · May 10, 2005

I noticed something today...

I have $28.10 in my credit voucher account balance. I chose to use it towards an order by checking the box and it grayed out all other payment options.

Since the item ordered had free shipping and no tax, the full amount was to be used to pay 100% of the order.

It kept giving me the error that I need to choose a payment option, but the CV balance took care of the full amount so no payment option was needed and even if it was, they are grayed out so I can not choose one anyway.

What should I do?

coolthings.com.au · May 10, 2005

Hi Jacob, thanks for that, the problem is that with Discount Vouchers the discount doesn't get applied at all to the total.
But if I refresh the confirmation pg, it then does.. weird.

I tried messing with sort orders and putting ob_start() and ob_end_flush() in the confirmation page to try & get the whole page buffered before output. Didn't work, I'm still lost... cheers, Bill

<{POST_SNAPBACK}>

I have the same problem, has anyone got a fix for this?

Peter.

Credit Class/Gift Vouchers/Discount Coupons 5.10

Recommended Posts

PopTheTop

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

audioeq

Guest

harry216

Tanaka

Irin

PopTheTop

rose3694

PopTheTop

rose3694

AmethystHaze

AmethystHaze

Deskdirect

firbest

jonyo

unai

leitel

firbest

Steel

chrisr63

Guest

Guest

coolthings.com.au

PopTheTop

coolthings.com.au

Join the conversation

Browse

Activity