Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Credit Class/Gift Vouchers/Discount Coupons 5.10


Strider

Recommended Posts

Then it is probably a javascript error... do you get any yellow triangle errors in the bottom left of your IE at anytime during your time on the checkout_payment page?

 

no..sadly

Link to comment
Share on other sites

  • Replies 4.8k
  • Created
  • Last Reply

Top Posters In This Topic

Okay, here is the javascript from my rendered page. when I dont have a peyment method checked and i click the redeem button i do get the error to check payment monthod. once i check a payment method i no longer get an error, nothing happens, no javascript errors or anything.

 

<script language="javascript"><!--
var selected;
var submitter = null;
function submitFunction() {
  submitter = 1;
  }
function selectRowEffect(object, buttonSelect) {

 // #################### Begin Added CGV JONYO ######################
 if (!document.checkout_payment.payment[0].disabled){
 // #################### End Added CGV JONYO ######################
if (!selected) {

if (document.getElementById) {
  selected = document.getElementById('defaultSelected');
} else {
  selected = document.all['defaultSelected'];
}
 }

 if (selected) selected.className = 'moduleRow';
 object.className = 'moduleRowSelected';
 selected = object;

// one button is not an array
 if (document.checkout_payment.payment[0]) {
document.checkout_payment.payment[buttonSelect].checked=true;
 } else {
document.checkout_payment.payment.checked=true;
 }
// #################### Begin Added CGV JONYO ######################
 }
// #################### End Added CGV JONYO ######################
}

function rowOverEffect(object) {
 if (object.className == 'moduleRow') object.className = 'moduleRowOver';
}

function rowOutEffect(object) {
 if (object.className == 'moduleRowOver') object.className = 'moduleRow';
}


function clearRadeos(){
document.checkout_payment.cot_gv.checked=!document.checkout_payment.cot_gv.checked;
}
//--></script>

<script language="javascript"><!-- 
function check_form() {
 var error = 0;
 var error_message = "Errors have occured during the process of your form.\n\nPlease make the following corrections:\n\n";
 var payment_value = null;
 if (document.checkout_payment.payment.length) {
for (var i=0; i<document.checkout_payment.payment.length; i++) {
  if (document.checkout_payment.payment[i].checked) {
	payment_value = document.checkout_payment.payment[i].value;
  }
}
 } else if (document.checkout_payment.payment.checked) {
payment_value = document.checkout_payment.payment.value;
 } else if (document.checkout_payment.payment.value) {
payment_value = document.checkout_payment.payment.value;
 }

 if (payment_value == "cc") {
var cc_owner = document.checkout_payment.cc_owner.value;
var cc_number = document.checkout_payment.cc_number.value;
if (cc_owner == "" || cc_owner.length < 3) {
  error_message = error_message + "* The owner's name of the credit card must be at least 3 characters.\n";
  error = 1;
}
if (cc_number == "" || cc_number.length < 10) {
  error_message = error_message + "* The credit card number must be at least 10 characters.\n";
  error = 1;
}
 }

 if (payment_value == null && submitter != 1) {
error_message = error_message + "* Please select a payment method for your order.\n";
error = 1;
 }

 if (error == 1 && submitter != 1) {
alert(error_message);
return false;
 } else {
return true;
 }
}
//--></script>

 

here is the checkout_payment.php

 

<?php
/*
 $Id: checkout_payment.php,v 1.113 2003/06/29 23:03:27 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License
*/

 require('includes/application_top.php');

// #################### Begin Added CGV JONYO ######################
if (tep_session_is_registered('cot_gv')) tep_session_unregister('cot_gv');  //added to reset whether a gift voucher is used or not on this order
// #################### End Added CGV JONYO ######################

// if the customer is not logged on, redirect them to the login page
 if (!tep_session_is_registered('customer_id')) {
$navigation->set_snapshot();
tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL'));
 }

// if there is nothing in the customers cart, redirect them to the shopping cart page
 if ($cart->count_contents() < 1) {
tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));
 }

// if no shipping method has been selected, redirect the customer to the shipping method selection page
 if (!tep_session_is_registered('shipping')) {
tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));
 }

// avoid hack attempts during the checkout procedure by checking the internal cartID
 if (isset($cart->cartID) && tep_session_is_registered('cartID')) {
if ($cart->cartID != $cartID) {
  tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));
}
 }

// if we have been here before and are coming back get rid of the credit covers variable
// #################### Added CGV ######################
if(tep_session_is_registered('credit_covers')) tep_session_unregister('credit_covers');  // CCGV Contribution
if(tep_session_is_registered('cot_gv')) tep_session_unregister('cot_gv'); //CCGV
// #################### End Added CGV ######################

// Stock Check
 if ( (STOCK_CHECK == 'true') && (STOCK_ALLOW_CHECKOUT != 'true') ) {
$products = $cart->get_products();
for ($i=0, $n=sizeof($products); $i<$n; $i++) {
  if (tep_check_stock($products[$i]['id'], $products[$i]['quantity'])) {
	tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));
	break;
  }
}
 }
// #################### Begin Added CGV JONYO ######################
// #################### THIS MOD IS OPTIONAL! ######################

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($shipping);

// #################### End Added CGV JONYO ######################
// #################### THIS MOD WAS OPTIONAL! ######################

// if no billing destination address was selected, use the customers own address as default
 if (!tep_session_is_registered('billto')) {
tep_session_register('billto');
$billto = $customer_default_address_id;
 } else {
// verify the selected billing address
$check_address_query = tep_db_query("select count(*) as total from " . TABLE_ADDRESS_BOOK . " where customers_id = '" . (int)$customer_id . "' and address_book_id = '" . (int)$billto . "'");
$check_address = tep_db_fetch_array($check_address_query);

if ($check_address['total'] != '1') {
  $billto = $customer_default_address_id;
  if (tep_session_is_registered('payment')) tep_session_unregister('payment');
}
 }

 require(DIR_WS_CLASSES . 'order.php');
 $order = new order;
// #################### Added CGV ######################
 require(DIR_WS_CLASSES . 'order_total.php');//ICW ADDED FOR CREDIT CLASS SYSTEM
 $order_total_modules = new order_total;//ICW ADDED FOR CREDIT CLASS SYSTEM
 $order_total_modules->clear_posts(); // ADDED FOR CREDIT CLASS SYSTEM by Rigadin in v5.13
// #################### End Added CGV ######################

 if (!tep_session_is_registered('comments')) tep_session_register('comments');

 $total_weight = $cart->show_weight();
 $total_count = $cart->count_contents();
// #################### Added CGV ######################
 $total_count = $cart->count_contents_virtual(); //ICW ADDED FOR CREDIT CLASS SYSTEM
// #################### End Added CGV ######################

// load all enabled payment modules
 require(DIR_WS_CLASSES . 'payment.php');
 $payment_modules = new payment;

 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CHECKOUT_PAYMENT);

 $breadcrumb->add(NAVBAR_TITLE_1, tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));
 $breadcrumb->add(NAVBAR_TITLE_2, tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'));
?>
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">
<title><?php echo TITLE; ?></title>
<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">
<link rel="stylesheet" type="text/css" href="stylesheet.css">
<script language="javascript"><!--
var selected;
<?php // #################### Added CGV ###################### ?>
var submitter = null;
function submitFunction() {
  submitter = 1;
  }
<?php // #################### End Added CGV ###################### ?>
function selectRowEffect(object, buttonSelect) {

 // #################### Begin Added CGV JONYO ######################
 if (!document.checkout_payment.payment[0].disabled){
 // #################### End Added CGV JONYO ######################
if (!selected) {

if (document.getElementById) {
  selected = document.getElementById('defaultSelected');
} else {
  selected = document.all['defaultSelected'];
}
 }

 if (selected) selected.className = 'moduleRow';
 object.className = 'moduleRowSelected';
 selected = object;

// one button is not an array
 if (document.checkout_payment.payment[0]) {
document.checkout_payment.payment[buttonSelect].checked=true;
 } else {
document.checkout_payment.payment.checked=true;
 }
// #################### Begin Added CGV JONYO ######################
 }
// #################### End Added CGV JONYO ######################
}

function rowOverEffect(object) {
 if (object.className == 'moduleRow') object.className = 'moduleRowOver';
}

function rowOutEffect(object) {
 if (object.className == 'moduleRowOver') object.className = 'moduleRow';
}

<?php // #################### Begin Added CGV JONYO ###################### ?>

<?php
if (MODULE_ORDER_TOTAL_INSTALLED)
$temp=$order_total_modules->process();
$temp=$temp[count($temp)-1];
$temp=$temp['value'];

$gv_query = tep_db_query("select amount from " . TABLE_COUPON_GV_CUSTOMER . " where customer_id = '" . $customer_id . "'");
$gv_result = tep_db_fetch_array($gv_query);

if ($gv_result['amount']>=$temp){ $coversAll=true;

?>

function clearRadeos(){
document.checkout_payment.cot_gv.checked=!document.checkout_payment.cot_gv.checked;
for (counter = 0; counter < document.checkout_payment.payment.length; counter++)
{
// If a radio button has been selected it will return true
// (If not it will return false)
if (document.checkout_payment.cot_gv.checked){
document.checkout_payment.payment[counter].checked = false;
document.checkout_payment.payment[counter].disabled=true;
//document.checkout_payment.cot_gv.checked=false;
} else {
document.checkout_payment.payment[counter].disabled=false;
//document.checkout_payment.cot_gv.checked=true;
}
}
}<?php } else { $coversAll=false;?>
function clearRadeos(){
document.checkout_payment.cot_gv.checked=!document.checkout_payment.cot_gv.checked;
}<?php } ?>
<?php // #################### End Added CGV JONYO ###################### ?>

//--></script>

<?php // #################### Begin Added CGV JONYO ###################### ?>
<?php // echo $payment_modules->javascript_validation(); ?>
<?php echo $payment_modules->javascript_validation($coversAll); ?>
<?php // #################### End Added CGV JONYO ###################### ?>

</head>
<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
<!-- header //-->
<?php require(DIR_WS_INCLUDES . 'header.php'); ?>
<!-- header_eof //-->

<!-- body //-->
<table border="0" width="100%" cellspacing="3" cellpadding="3">
 <tr>
<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- left_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>
<!-- left_navigation_eof //-->
</table></td>
<!-- body_text //-->
<td width="100%" valign="top">
<?php
// #################### Added CGV JONYO ######################
// echo tep_draw_form('checkout_payment', tep_href_link(FILENAME_CHECKOUT_CONFIRMATION, '', 'SSL'), 'post', 'onsubmit="return check_form();"'); 
// #################### End Added CGV JONYO ######################
?><table border="0" width="100%" cellspacing="0" cellpadding="0">
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="0">
	  <tr>
		<td class="pageHeading"><?php echo HEADING_TITLE; ?></td>
		<td class="pageHeading" align="right"><?php echo tep_image(DIR_WS_IMAGES . 'table_background_payment.gif', HEADING_TITLE, HEADING_IMAGE_WIDTH, HEADING_IMAGE_HEIGHT); ?></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
<?php
 if (isset($HTTP_GET_VARS['payment_error']) && is_object(${$HTTP_GET_VARS['payment_error']}) && ($error = ${$HTTP_GET_VARS['payment_error']}->get_error())) {
?>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
		<td class="main"><b><?php echo tep_output_string_protected($error['title']); ?></b></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBoxNotice">
	  <tr class="infoBoxNoticeContents">
		<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
		  <tr>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			<td class="main" width="100%" valign="top"><?php echo tep_output_string_protected($error['error']); ?></td>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
		  </tr>
		</table></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
<?php
 }
?>
<?php // #################### Begin Added CGV JONYO ###################### ?>
<?php // #################### THIS MOD IS OPTIONAL! ###################### ?>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
		<td class="main"><b><?php echo HEADING_PRODUCTS; ?></b><?  echo ' <a href="' . tep_href_link(FILENAME_SHOPPING_CART) . '"><span class="orderEdit">(' . TEXT_EDIT . ')</span></a>'; ?></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
<tr class="infoBoxContents">
		<td>
 <table border="0" width="100%" cellspacing="0" cellpadding="2">
<?php
//}

for ($i=0, $n=sizeof($order->products); $i<$n; $i++) {
  echo '		  <tr>' . "\n" .
	'			<td width="10%" class="main" align="right" valign="top" width="30">' . $order->products[$i]['qty'] . ' x</td>' . "\n" .
	'			<td width="60%" class="main" valign="top">' . $order->products[$i]['name'];

  if (STOCK_CHECK == 'true') {
 echo tep_check_stock($order->products[$i]['id'], $order->products[$i]['qty']);
  }

  if ( (isset($order->products[$i]['attributes'])) && (sizeof($order->products[$i]['attributes']) > 0) ) {
 for ($j=0, $n2=sizeof($order->products[$i]['attributes']); $j<$n2; $j++) {
   echo '<br><nobr><small> <i> - ' . $order->products[$i]['attributes'][$j]['option'] . ': ' . $order->products[$i]['attributes'][$j]['value'] . '</i></small></nobr>';
 }
  }

  echo '</td>' . "\n";

  if (sizeof($order->info['tax_groups']) > 1) echo '			<td class="main" valign="top" align="right">' . tep_display_tax_value($order->products[$i]['tax']) . '% </td>' . "\n";

  echo '			<td width="30%"class="main" align="right" valign="top">' . $currencies->display_price($order->products[$i]['final_price'], $order->products[$i]['tax'], $order->products[$i]['qty']) . ' </td>' . "\n" .
	'		  </tr>' . "\n";
}
?>
			<tr>
		<td COLSPAN="3" valign="top" align="right">
	   <table border="0" cellspacing="0" cellpadding="3">
<?php
if (MODULE_ORDER_TOTAL_INSTALLED) {
  //$temp=$order_total_modules->process();
  echo $order_total_modules->output();
}
?>
				</table>
	 </td>
	  </tr>
  </table>
  </td>
	  </tr>
	</table></td>
  </tr>
<!--			  </table></td>
		 </tr-->
<?php // #################### End Added CGV JONYO ###################### ?>
<?php // #################### THIS MOD WAS OPTIONAL! ###################### ?>

  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
		<td class="main"><b><?php echo TABLE_HEADING_BILLING_ADDRESS; ?></b></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
		<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
		  <tr>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> 
			<td class="main" width="50%" valign="top"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?><br><br><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_PAYMENT_ADDRESS, '', 'SSL') . '">' . tep_image_button('button_change_address.gif', IMAGE_BUTTON_CHANGE_ADDRESS) . '</a>'; ?></td>
			<td align="right" width="50%" valign="top"><table border="0" cellspacing="0" cellpadding="2">
			  <tr>
				<td class="main" align="center" valign="top"><b><?php echo TITLE_BILLING_ADDRESS; ?></b><br><?php echo tep_image(DIR_WS_IMAGES . 'arrow_south_east.gif'); ?></td>
				<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> 
				<td class="main" valign="top"><?php echo tep_address_label($customer_id, $billto, true, ' ', '<br>'); ?></td>
				<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> 
			  </tr>
			</table></td>
		  </tr>
		</table></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
		<td class="main"><b><?php echo TABLE_HEADING_PAYMENT_METHOD; ?></b></td>
	  </tr>
	</table></td>
<?php // #################### Added CGV ###################### 
 echo $order_total_modules->credit_selection();//ICW ADDED FOR CREDIT CLASS SYSTEM
// #################### End Added CGV ###################### ?>
  </tr>
  <tr>
	<td>

<?php
// #################### End Added CGV JONYO ######################
 echo tep_draw_form('checkout_payment', tep_href_link(FILENAME_CHECKOUT_CONFIRMATION, '', 'SSL'), 'post', 'onsubmit="return check_form();"'); 
// #################### End Added CGV JONYO ######################
?>

<table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
		<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
<?php
 $selection = $payment_modules->selection();

 if (sizeof($selection) > 1) {
?>
		  <tr>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			<td class="main" width="50%" valign="top"><?php echo TEXT_SELECT_PAYMENT_METHOD; ?></td>
			<td class="main" width="50%" valign="top" align="right"><b><?php echo TITLE_PLEASE_SELECT; ?></b><br><?php echo tep_image(DIR_WS_IMAGES . 'arrow_east_south.gif'); ?></td>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
		  </tr>
<?php
 } else {
?>
		  <tr>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			<td class="main" width="100%" colspan="2"><?php echo TEXT_ENTER_PAYMENT_INFORMATION; ?></td>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
		  </tr>
<?php
 }

 $radio_buttons = 0;
 for ($i=0, $n=sizeof($selection); $i<$n; $i++) {
?>
		  <tr>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			<td colspan="2"><table border="0" width="100%" cellspacing="0" cellpadding="2">
<?php
if ( ($selection[$i]['id'] == $payment) || ($n == 1) ) {
  echo '				  <tr id="defaultSelected" class="moduleRowSelected" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";
} else {
  echo '				  <tr class="moduleRow" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";
}
?>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
				<td class="main" colspan="3"><b><?php echo $selection[$i]['module']; ?></b></td>
				<td class="main" align="right">
<?php
if (sizeof($selection) > 1) {
  echo tep_draw_radio_field('payment', $selection[$i]['id']);
} else {
  echo tep_draw_hidden_field('payment', $selection[$i]['id']);
}
?>
				</td>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			  </tr>
<?php
if (isset($selection[$i]['error'])) {
?>
			  <tr>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
				<td class="main" colspan="4"><?php echo $selection[$i]['error']; ?></td>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			  </tr>
<?php
} elseif (isset($selection[$i]['fields']) && is_array($selection[$i]['fields'])) {
?>
			  <tr>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
				<td colspan="4"><table border="0" cellspacing="0" cellpadding="2">
<?php
  for ($j=0, $n2=sizeof($selection[$i]['fields']); $j<$n2; $j++) {
?>
				  <tr>
					<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
					<td class="main"><?php echo $selection[$i]['fields'][$j]['title']; ?></td>
					<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
					<td class="main"><?php echo $selection[$i]['fields'][$j]['field']; ?></td>
					<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
				  </tr>
<?php
  }
?>
				</table></td>
				<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			  </tr>
<?php
}
?>
			</table></td>
			<td><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
		  </tr>
<?php
$radio_buttons++;
 }

// #################### Begin Added CGV JONYO ######################

if (tep_session_is_registered('customer_id')) {
if ($gv_result['amount']>0){
 echo ' <tr><td width="10">' .  tep_draw_separator('pixel_trans.gif', '10', '1') .'</td><td colspan=2>' . "\n" .
							  ' <table border="0" cellpadding="2" cellspacing="0" width="100%"><tr class="moduleRow" onmouseover="rowOverEffect(this)" onclick="clearRadeos()" onmouseout="rowOutEffect(this)" >' . "\n" .
						 '   <td width="10">' .  tep_draw_separator('pixel_trans.gif', '10', '1') .'</td><td class="main">' . $gv_result['text'];

 echo $order_total_modules->sub_credit_selection();
 }
}


// #################### End Added CGV JONYO ######################

?>
		</table></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
		<td class="main"><b><?php echo TABLE_HEADING_COMMENTS; ?></b></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
		<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
		  <tr>
			<td><?php echo tep_draw_textarea_field('comments', 'soft', '60', '5'); ?></td>
		  </tr>
		</table></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
		<td><table border="0" width="100%" cellspacing="0" cellpadding="2">
		  <tr>
			<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
			<td class="main"><b><?php echo TITLE_CONTINUE_CHECKOUT_PROCEDURE . '</b><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?></td>
			<td class="main" align="right"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></td>
			<td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
		  </tr>
		</table></td>
	  </tr>
	</table></td>
  </tr>
  <tr>
	<td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
	<td><table border="0" width="100%" cellspacing="0" cellpadding="0">
	  <tr>
		<td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
		  <tr>
			<td width="50%" align="right"><?php echo tep_draw_separator('pixel_silver.gif', '1', '5'); ?></td>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		  </tr>
		</table></td>
		<td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
		  <tr>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
			<td><?php echo tep_image(DIR_WS_IMAGES . 'checkout_bullet.gif'); ?></td>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		  </tr>
		</table></td>
		<td width="25%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
		<td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
		  <tr>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td>
			<td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '1', '5'); ?></td>
		  </tr>
		</table></td>
	  </tr>
	  <tr>
		<td align="center" width="25%" class="checkoutBarFrom"><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL') . '" class="checkoutBarFrom">' . CHECKOUT_BAR_DELIVERY . '</a>'; ?></td>
		<td align="center" width="25%" class="checkoutBarCurrent"><?php echo CHECKOUT_BAR_PAYMENT; ?></td>
		<td align="center" width="25%" class="checkoutBarTo"><?php echo CHECKOUT_BAR_CONFIRMATION; ?></td>
		<td align="center" width="25%" class="checkoutBarTo"><?php echo CHECKOUT_BAR_FINISHED; ?></td>
	  </tr>
	</table></td>
  </tr>
</table></form></td>
<!-- body_text_eof //-->
<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- right_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>
<!-- right_navigation_eof //-->
</table></td>
 </tr>
</table>
<!-- body_eof //-->

<!-- footer //-->
<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>
<!-- footer_eof //-->
<br>
</body>
</html>
<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

Link to comment
Share on other sites

That's a massive post!

 

PM me with your URL, that'll be better so i can see first hand.

Edited by chooch

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

heh this contrib hates me with a passion!

 

working now the issue is

 

checkout_payment.php?payment_error=ot_coupon&error=Invalid+Coupon+Code

 

The amp; is there and shouldnt be..anyone have any ideas?

Link to comment
Share on other sites

I am upgrading to 5.18 and am able to get the coupons working with no problem after looking through the forum but the vouchers are another story: I sent myself a test voucher for $50.00 but when I get to the payment page and put a checkmark in the box to pay with the gift voucher then click on 'Continue' the error box pops up and tells me to select a payment method yet, all other payment methods are grayed out and unavailable once I put the checkmark in. I realize someone said a few pages back that the solution is in this thread but I have not been able to find it (though I found 2 posts with people having the same problem) so if someone could give me a date range, page range or just a clue in general I would really appreciate it.

 

 

 

Also, I ran into some of the language issues and when combing through the contrib found that several of the define's were simply missing so I pulled them out of an older version (I tried to weed out those that are duplicated in the newer version but may have missed 1 or 2) and here they are if it helps anyone else:

admin/includes/languages/english/modules/order_total/ot_coupon.php

define('MODULE_ORDER_TOTAL_COUPON_USER_PROMPT', '');

define('ERROR_NO_INVALID_REDEEM_COUPON', 'Invalid Coupon Code');

define('ERROR_INVALID_STARTDATE_COUPON', 'This coupon is not available yet');

define('ERROR_INVALID_FINISDATE_COUPON', 'This coupon has expired');

define('ERROR_INVALID_USES_COUPON', 'This coupon could only be used ');

define('TIMES', ' time(s).');

define('ERROR_INVALID_USES_USER_COUPON', 'You have used the coupon the maximum number of times allowed per customer.');

define('REDEEMED_MIN_ORDER', 'on orders over ');

define('REDEEMED_RESTRICTIONS', ' [Product-Category restrictions apply]');

 

admin/includes/languages/add_ccgvdc_english.php

define('BOX_REPORTS_CREDITS', 'Current Customer Credits');

 

English only:

admin/includes/languages/english/stats_credits.php

change this:

define('HEADING_TITLE', 'Aktuelles Kundenguthaben');

to this:

define('HEADING_TITLE', 'Current Customer Credits');

Link to comment
Share on other sites

Hello!

 

CC&GV calculates wrong total tax when use Discount amount:

 

Sub-Total: $20.00

Discount Coupons:10%: -$2.00

Table Rate (Best Way): $0.00

net: $14.95 <== MUST BE $15,25

PVN 18%: $3.05 <== MUST BE $2,75

Total: $18.00

Link to comment
Share on other sites

Hello!

 

CC&GV calculates wrong total tax when use Discount amount:

 

Sub-Total: $20.00

Discount Coupons:10%: -$2.00

Table Rate (Best Way): $0.00

net: $14.95 <== MUST BE $15,25

PVN 18%: $3.05 <== MUST BE $2,75

Total: $18.00

No it doesn't... re-arrange your order totals to the defaulted way and eveything will be ok.

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

Stupid question (perhaps)

 

Can someone tell me how to setup a Gift Voucher as a product?

 

I'm using CreLoaded...

 

I can email a voucher from admin and redeem it, but cannot find anywhere to create it as a a product.

 

Many Thanks

Link to comment
Share on other sites

I have changed Include Tax to "false" and Re-Calculate Tax to "Standard", seems that calculation is ok, but dicount coupon amount it shows without Tax:

 

Sub-Total: $20.00

Discount Coupons:10%: -$1.69 <= shows without Tax, must be -$2.00

Table Rate (Best Way): $0.00

net: $15.26

PVN 18%: $2.75

Total: $18.00

 

If i change Include Tax to "true", then it calculate this:

Sub-Total: $20.00

Discount Coupons:10%: -$2.00

Table Rate (Best Way): $0.00

net: $14.95 <= WRONG

PVN 18%: $2.75 <= RIGHT

Total: $17.69 <= WRONG

Link to comment
Share on other sites

I'm using CreLoaded...

Why not ask on the creloaded forum.. this forum is for oscommerce not creloaded and others.

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

I have changed Include Tax to "false" and Re-Calculate Tax to "Standard", seems that calculation is ok, but dicount coupon amount it shows without Tax:

Again, set up your order totals back to the default settings then everything will be ok.

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

I need that Discount amount is before Tax and Total.

So, i just added one line to ot_coupon.php in function process() {

if ($od_amount > 0) {

$order->info['total'] = $order->info['total'] - $od_amount;

$od_amount = $order->info['subtotal'] - $order->info['total']; <= THIS LINE

$this->output[] = array('title' => $this->title . ': ' . $this->coupon_code .':','text' => '<b>-' . $currencies->format($od_amount) . '</b>', 'value' => $od_amount); //Fred added hyphen

}

 

And now it looks as i need.

 

One more bug, i think.

In order total modules, if Gift voucher sort order number is less than Discount Coupon sort order number, then at Payment Information page it is not possible to check Gift Voucher payment metod - there is error:

Line: 53

Char: 1

Error: 'document.checkout_payment.cot_gv' is null or not an object

Code: 0

Url: http://localhost/catalog/checkout_payment....ed+for+%2410.00

Link to comment
Share on other sites

Hi,

 

I was wondering if it is possible to exclude specials when using a discount code?

For example a 10% discount with 2 products in cart (each $10) but 1 of the products is a special would give only $1 discount instead of $2. Can this be done?

 

thanks!

 

Matt

Matthias Thoen

my contribution: Photo Gallery for osCommerce

--check my homepage in my CARD--

Link to comment
Share on other sites

Hi Guys,

 

Great contribution! It really is ideal for what i want to do..

 

I've got it all installed great, first time, no errors etc etc.. which is usually a good sign. (Version 5.16 btw)

 

Just noticed that when i put the coupon code in the redeem box and hit "redeem" i get the following error message even though the order is within the specifics i entered in admin...

 

Coupon Redemption

 

The coupon has been successfully applied for ***HOWEVER:No reducion available, please see the coupon restrictions***

 

If i then go straight back to the redeem box and put the code in again it works, adds perfectly to the cart and tells me its worked successfully.. Any ideas how to resolve this ?

 

Thanks in advance! :thumbsup:

Link to comment
Share on other sites

I have the CCGV installed, but I have this file: catalog/admin/treeview.php & am not sure what it is for. Can anyone tell me?

If it is part of the download why not just add it, then you will see what it does? You use that file to restrict items where coupon codes are to be redeemed.

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

If it is part of the download why not just add it, then you will see what it does? You use that file to restrict items where coupon codes are to be redeemed.

 

Any idea about my problem Chooch ?

 

I have to add the vouchers twice to make them work :|

Edited by sp_
Link to comment
Share on other sites

If it is part of the download why not just add it, then you will see what it does? You use that file to restrict items where coupon codes are to be redeemed.

I took screenshots of the coupon area of my admin & uploaded them to a testing server. Look at my pages...I don't see the treeview.php file contents anywheres. I did go to the catalog/admin/treeview.php & see that it is listing my categories & products in a expanding & collapsing treeview. I get those popup windows when I click on the " View " next to the product & category input boxes.

 

image1.gif

product_list.gif

category_list.gif

Link to comment
Share on other sites

I get those popup windows when I click on the " View " next to the product & category input boxes.

Thats what you get.. you are supposed to look at the id codes and add them to the category/product to restrict usage.

 

If you add the treeview update then you basically tick a checkbox to restrict - i can't get clearer than this:

if you have uploaded a file called treeview.php and all the files associated with it to make it work then your pop-up would be different, i can only assume you haven't.

 

I can't post any more on this treeview stuff because I haven't downloaded this contribution for maybe 18 months and I can't really remember anymore... anyway it isn't the most important part of CCGV and the contribution runs perfectly without it, the treeview is NOT a necessity nor a big deal.

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

I have to add the vouchers twice to make them work :|

Umm, well there was something posted about this ages ago but there could be more than one reason it's happening.

 

I tried to find the post from around page 75 onwards and got to 78 and gave up. I think I found a post somewhere around those pages with a fix - sorry, you'll have to find it yourself.

Edited by chooch

Upon receiving fixes and advice, too many people don't bother to post updates informing the forum of how it went. Until of course they need help again on other issues and they come running back!

 

Why receive the information you require in good faith for free, only to then have the attitude to ignore the people who gave it to you?

 

There's no harm in saying, 'Thanks, it worked'. On the contrary, it creates a better atmosphere.

 

CHOOCH

Link to comment
Share on other sites

Umm, well there was something posted about this ages ago but there could be more than one reason it's happening.

 

I tried to find the post from around page 75 onwards and got to 78 and gave up. I think I found a post somewhere around those pages with a fix - sorry, you'll have to find it yourself.

I think that it was fixed in one of the packages, but can't remember which.

Link to comment
Share on other sites

I think that it was fixed in one of the packages, but can't remember which.

 

Cheers guys i'll carry on from page 75 and see if i can find anything....

 

A pakage added after CCGV version 5.16 - 8th Feb 2006 do you think Coopco ?

Edited by sp_
Link to comment
Share on other sites

Just been searching through this large post becuase i got to page 108 and got really annoyed..

 

I found this post:

http://www.oscommerce.com/forums/index.php?sho...518&st=3800

 

By jenamiles who has the same problem as me, just wondering if there was a fix posted up for it at all ?

 

I also read somewhere by Chooch saying that version 510c (i think it was) was the best stable version of this great contribution would it be worth me installing this version instead ?

 

Also is this: http://www.oscommerce.com/community/contributions,4135 (CCGV(trad)) version 510c ?

Link to comment
Share on other sites

Just been searching through this large post becuase i got to page 108 and got really annoyed..

 

I found this post:

http://www.oscommerce.com/forums/index.php?sho...518&st=3800

 

By jenamiles who has the same problem as me, just wondering if there was a fix posted up for it at all ?

 

I also read somewhere by Chooch saying that version 510c (i think it was) was the best stable version of this great contribution would it be worth me installing this version instead ?

 

Also is this: http://www.oscommerce.com/community/contributions,4135 (CCGV(trad)) version 510c ?

I ended installing CCGV 5.15 a2 parts 1 and 2 by Shane Jackson into my test site. It works for me.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...