ammsimon Posted July 16, 2019 Share Posted July 16, 2019 excuse me for "robot".the urls work very well on the site, no problems.This is googlebot, msnbot ...They visit the url re-write by adding the ID in addition, as on my exampleIt's weirdThank you. Quote Osc 2.3.4 mts template Link to comment Share on other sites More sharing options...
Jack_mcs Posted July 16, 2019 Share Posted July 16, 2019 If you are using a sitemap, take a look at it to make sure the url's are correct. If it is one you generated from some external site, it was probably not created correctly. Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
Hotclutch Posted July 16, 2019 Share Posted July 16, 2019 7 hours ago, ammsimon said: excuse me for "robot".the urls work very well on the site, no problems.This is googlebot, msnbot ...They visit the url re-write by adding the ID in addition, as on my exampleIt's weirdThank you. Someone posted a similar type problem just a few posts back from yours. You need to find where in your script it is generating these parameters and then fix it, by adding code possibly. Even if the problem is already fixed / removed, google will continue to crawl the URLs indefinitely, until you put a 301 redirect on URLs of that type. A quick fix for Google would be to ignore those parameters in webmaster tools, MSN also has an ignore parameter tool. Quote Link to comment Share on other sites More sharing options...
ammsimon Posted July 17, 2019 Share Posted July 17, 2019 Thank you for your answers. My canonical tags are ok, pagination too (page2, 3 ..If I have to make 301 individual ad tags it's about 1500 line on my htaccess. aie, aie, aie in french ! Quote Osc 2.3.4 mts template Link to comment Share on other sites More sharing options...
ammsimon Posted July 21, 2019 Share Posted July 21, 2019 (edited) In htaccess the 301 test redirects as below do not work RewriteRule ^my-product-name-p-796.html?products_id=796.html$ https://www.mysite.com/my-product-name-p-796.html Redirect permanent /my-product-name-p-796.html?products_id=796.html https://www.mysite.com/my-product-name-p-796.html I think I'll leave like this Edited July 21, 2019 by ammsimon Incomplete Quote Osc 2.3.4 mts template Link to comment Share on other sites More sharing options...
BrockleyJohn Posted July 21, 2019 Share Posted July 21, 2019 1 hour ago, ammsimon said: In htaccess the 301 test redirects as below do not work RewriteRule ^my-product-name-p-796.html?products_id=796.html$ https://www.mysite.com/my-product-name-p-796.html Redirect permanent /my-product-name-p-796.html?products_id=796.html https://www.mysite.com/my-product-name-p-796.html I think I'll leave like this It is probably not important to redirect these urls as I expect they work ok. However, they almost certainly come from your site, likely to be from a coding error. You can find out where the links are being created using the internal links report in Google search console. If you want some help with this, create a separate topic and I can talk you through how to do this. Quote Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
Hotclutch Posted July 21, 2019 Share Posted July 21, 2019 4 hours ago, ammsimon said: In htaccess the 301 test redirects as below do not work RewriteRule ^my-product-name-p-796.html?products_id=796.html$ https://www.mysite.com/my-product-name-p-796.html Redirect permanent /my-product-name-p-796.html?products_id=796.html https://www.mysite.com/my-product-name-p-796.html I think I'll leave like this That's invalid syntax. You cannot redirect query strings like that in htaccess. You can do more harm than good when experimenting with htaccess like this, my suggestion is not to make entries in htaccess until the code you put is fully tested by someone who knows htaccess rules (which are complex). On 7/16/2019 at 5:36 PM, Hotclutch said: A quick fix for Google would be to ignore those parameters in webmaster tools, MSN also has an ignore parameter tool. Just do this for now. Quote Link to comment Share on other sites More sharing options...
mhsuffolk Posted August 11, 2019 Share Posted August 11, 2019 Phoenix 1.0.1.4 PHP 7.3 Test site on XAMPP Installed and works correctly, URLs are as I have them on my live site. However at the top of every page I get this. Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\********\htdocs\includes\classes\seo.class.php on line 1883 Quote Live shop Phoenix 1.0.8.4 on PHP 7.4 Working my way up the versions. Link to comment Share on other sites More sharing options...
Jack_mcs Posted August 11, 2019 Share Posted August 11, 2019 At line 1883 in the includes/classes/seo,class.php filem change continue; to continue 2; mhsuffolk 1 Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
magak2015 Posted November 8, 2019 Share Posted November 8, 2019 Hi I want to export all my dynamic generated HTML URLs to a .csv file or similar. Can anyone point me to how I should try this? I thought it was some value stored in the database but I see its not so easy... Quote Link to comment Share on other sites More sharing options...
♥ecartz Posted November 8, 2019 Share Posted November 8, 2019 30 minutes ago, magak2015 said: I want to export all my dynamic generated HTML URLs to a .csv file or similar. I do not know the answer. But if I were trying to do this, I would look at sitemap Apps. Why? Because they generate listings of URLs and should use the same generation mechanism as osCommerce uses for regular links. Perhaps not all of them would be compatible with this App, but at least one should. magak2015 1 Quote Always back up before making changes. Link to comment Share on other sites More sharing options...
magak2015 Posted November 17, 2019 Share Posted November 17, 2019 Thanks ecartz, your advice was very helpful! Quote Link to comment Share on other sites More sharing options...
artfulweb Posted December 29, 2019 Share Posted December 29, 2019 Hello Jack, Just installed your latest version and all works except the character conversions. I entered à=>a,â=>a,æ=>ae,ç=>c,é=>e,è=>e,ê=>e,ë=>e,î=>i,ï=>i,œ=>oe,ô=>o,ö=>o,ù=>u,û=>u,À=>A,Â=>A,Æ=>AE,Ç=>C,È=>E,É=>E,Ê=>E,Ë=>E,Î=>I,Ï=>I,Œ=>OE,Ô=> O,Ù=>U,Û=>U,ü=>u,ÿ=>'y',€=>Euros but ther words with accents show up in the url as for example "lgumes" instead of "legumes", the character to be replaced not replaced! Any ideas? Thanks in advance Quote Link to comment Share on other sites More sharing options...
Jack_mcs Posted December 29, 2019 Share Posted December 29, 2019 I haven't tested it but I think the conversion is for characters. So where you are using more than one character, like Euros, it may not work. But for the others, it should. Try removing everything except à=>a and see if that works. Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
artfulweb Posted January 1, 2020 Share Posted January 1, 2020 On 12/29/2019 at 4:55 PM, Jack_mcs said: I haven't tested it but I think the conversion is for characters. So where you are using more than one character, like Euros, it may not work. But for the others, it should. Try removing everything except à=>a and see if that works. No, Jack, still does not work. Sorry Quote Link to comment Share on other sites More sharing options...
Jack_mcs Posted January 1, 2020 Share Posted January 1, 2020 What version of oscommerce and php are you using? Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
artfulweb Posted January 1, 2020 Share Posted January 1, 2020 Sorry for the delay Jack. I am running Phoenix v.1.0.4.1 with php 7.38. Quote Link to comment Share on other sites More sharing options...
domiosc Posted January 1, 2020 Share Posted January 1, 2020 PHP Version Minimum 7.0 Maximum 7.3 Superior version is possible? Quote Link to comment Share on other sites More sharing options...
artfulweb Posted January 1, 2020 Share Posted January 1, 2020 13 minutes ago, domiosc said: PHP Version Minimum 7.0 Maximum 7.3 Superior version is possible? On my hoster they upgraded 7.3 to 7.38... don't know the details Quote Link to comment Share on other sites More sharing options...
artfulweb Posted January 1, 2020 Share Posted January 1, 2020 Excuse me, 7.35 Quote Link to comment Share on other sites More sharing options...
Jack_mcs Posted January 2, 2020 Share Posted January 2, 2020 6 hours ago, artfulweb said: Sorry for the delay Jack. I am running Phoenix v.1.0.4.1 with php 7.38. I tried it here in a test shop and it failed for me too. It seems the php function used for the translating has problems with UTF code. Please try the following. Replace this line if ( is_array($this->attributes['SEO_CHAR_CONVERT_SET']) ) $string = strtr($string, $this->attributes['SEO_CHAR_CONVERT_SET']); with this if ( is_array($this->attributes['SEO_CHAR_CONVERT_SET']) ) $string = iconv('UTF-8', 'ASCII//TRANSLIT', $string); The above worked in my quick test but I suggest you test it more thoroughly. Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
artfulweb Posted January 2, 2020 Share Posted January 2, 2020 Really curious… with this correction "légumes" shows as "lacgumes" now, the "é" being replaced mysteriously by "ac". Here is what is configured: à=>a,â=>a,æ=>ae,ç=>c,é=>e,è=>e,ê=>e,ë=>e,î=>i,ï=>i,œ=>oe,ô=>o,ö=>o,ù=>u,û=>u,À=>A,Â=>A,Æ=>AE,Ç=>C,È=>E,É=>E,Ê=>E,Ë=>E,Î=>I,Ï=>I,Œ=>OE,Ô=> O,Ù=>U,Û=>U,ü=>u,ÿ=>y Quote Link to comment Share on other sites More sharing options...
artfulweb Posted January 2, 2020 Share Posted January 2, 2020 15 minutes ago, artfulweb said: Really curious… with this correction "légumes" shows as "lacgumes" now, the "é" being replaced mysteriously by "ac". Here is what is configured: à=>a,â=>a,æ=>ae,ç=>c,é=>e,è=>e,ê=>e,ë=>e,î=>i,ï=>i,œ=>oe,ô=>o,ö=>o,ù=>u,û=>u,À=>A,Â=>A,Æ=>AE,Ç=>C,È=>E,É=>E,Ê=>E,Ë=>E,Î=>I,Ï=>I,Œ=>OE,Ô=> O,Ù=>U,Û=>U,ü=>u,ÿ=>y I tried other products and no matter what accented letter is replaced it is replaced by this "ac". Where does it find that? Quote Link to comment Share on other sites More sharing options...
Jack_mcs Posted January 2, 2020 Share Posted January 2, 2020 Try this. Remove the last change then change this line $string = iconv("ISO-8859-1", "UTF-8//TRANSLIT", $string); to this $string = iconv('UTF-8', 'ASCII//TRANSLIT', $string); Also, probably not related to this, you have Ô=> O in your array. That would cause a space to be in the url causing it to fail. As mentioned previously, you should limit the conversion entry until the code is working to be sure parts of it are not causing other problems. valquiria23 1 Quote Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
artfulweb Posted January 2, 2020 Share Posted January 2, 2020 10 minutes ago, Jack_mcs said: Try this. Remove the last change then change this line $string = iconv("ISO-8859-1", "UTF-8//TRANSLIT", $string); to this $string = iconv('UTF-8', 'ASCII//TRANSLIT', $string); Also, probably not related to this, you have Ô=> O in your array. That would cause a space to be in the url causing it to fail. As mentioned previously, you should limit the conversion entry until the code is working to be sure parts of it are not causing other problems. That works! Thanks, Jack. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.