[CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

[Mikepo]

@Jack_mcs

thank you Jack, I upgraded to v2.2-17 and that solved my problem.  The URL is now visit-shop-i-6.html 😊

Regards

Mike

[Jack_mcs]

A new version has been uploaded. Itjust fixes the problem with the ConnectDB introduced in the last version. If you have applied the fix mentioned in this thread, you don't need the update. But if you want to apply it, just upload the includes/classes/seo.class.php file.

[♥altoid]

12 hours ago, Jack_mcs said:

A new version has been uploaded. Itjust fixes the problem with the ConnectDB introduced in the last version. If you have applied the fix mentioned in this thread, you don't need the update. But if you want to apply it, just upload the includes/classes/seo.class.php file.

Jack, I am two versions back on this.  Can I just install the latest or should I install each version incrementally?

I am currently at Version 2.2d-16

Thank you

Edited February 22, 2019 by altoid

[Jack_mcs]

1 hour ago, altoid said:

Can I just install the latest or should I install each version incrementally?

You should be able to just upload the seo.class.php file. There is a change to the code in the application_top.php file, which you found, that needs to be made to prevent warnings with php 7 but no other changes are needed.

[♥altoid]

On 2/22/2019 at 11:54 AM, Jack_mcs said:

You should be able to just upload the seo.class.php file. There is a change to the code in the application_top.php file, which you found, that needs to be made to prevent warnings with php 7 but no other changes are needed.

OK  thanks..for application_top.php the change was from

 if ((!defined(SEO_ENABLED)) || (SEO_ENABLED == 'true')) {
   include_once('includes/classes/seo.class.php');
   if ( ! (isset($seo_urls) && is_object($seo_urls)) ){
     $seo_urls = new SEO_URL($languages_id);
   }
 }

to

if ((!defined('SEO_ENABLED')) || (SEO_ENABLED == 'true')) {
  include_once('includes/classes/seo.class.php');
  if ( isset($seo_urls) && !is_object($seo_urls) ){
    $seo_urls = new SEO_URL($languages_id);
  }
}

if I have that correct.

Otherwise with the  new seo.class.php uploaded should be up to date then.

[Demitry]

@Jack_mcs

hi Jack,

I modified my product_reviews.php file in my BS Edge install to also display individual reviews,.. same as product_reviews_info.php file did in the older osC versions, before it was dropped for whatever reason.

The htaccess rewrite rules for the product_reviews.php file does not recognize any query in the url beyond products_id. Therefore, an individual review in that file with a url like this:

../product_reviews.php?products_id=19&reviews_id=3

…will ignore the last part and return the same product_reviews.php page showing all of the reviews for that product.

I tried finding a solution using an htaccess RewriteRule and cannot seem to get one to work properly. I’m doing this with the assumption that I don’t need to add code in the seo.class.php class file, though I may be wrong on that.

Do you or anyone else here know how to structure that RewriteRule for it to read the second part of that url query string?

[BrockleyJohn]

23 minutes ago, Demitry said:

@Jack_mcs

hi Jack,

I modified my product_reviews.php file in my BS Edge install to also display individual reviews,.. same as product_reviews_info.php file did in the older osC versions, before it was dropped for whatever reason.

 

The htaccess rewrite rules for the product_reviews.php file does not recognize any query in the url beyond products_id. Therefore, an individual review in that file with a url like this:

 

../product_reviews.php?products_id=19&reviews_id=3

 

…will ignore the last part and return the same product_reviews.php page showing all of the reviews for that product.

 

I tried finding a solution using an htaccess RewriteRule and cannot seem to get one to work properly. I’m doing this with the assumption that I don’t need to add code in the seo.class.php class file, though I may be wrong on that.

 

Do you or anyone else here know how to structure that RewriteRule for it to read the second part of that url query string?

 

I can't see why you want both parameters - surely it's one or the other? If so, then you need to express which parameter uniquely in the url by changing code in the class, so as well as pr representing the product id parameter on the reviews page, something like rr might represent the reviews page with a review id parameter. Then you have an extra rewrite rule to pick up the extra format.

[Demitry]

Quote

I can't see why you want both parameters - surely it's one or the other?

Thanks John, I had not thought of that. I figured it needed both and it works with both. I'll take a look and try restructuring the file to use one parameter (products_id) for all reviews and the reviews_id for the single review. The easiest way is probably to just scrap the split file and leave it as it was and then add in the product_reviews_info.php file. The SEO URLs code is already set up for it in the class file.

Edited March 6, 2019 by Demitry

[Owl Sauron]

Hi there

Im having problems with the Enter special character conversions...

ã=>a,õ=>o,á=>a,ç=>c,é=>e,ó=>o,ú=>u,í=>i,Ó=>O,ñ=>n,ê=>e

its not working.

Using osCommerce Online Merchant v2.3.4.1 CE on PHP7.0

Any thoughts?

[Jack_mcs]

I don't have a shop setup that uses more than English and is running with php 7 so I've no way to test this. You don't say what "its not working" means or what version of this addon you are using so I can only guess at things to try. The following are all I can think of:

- After you enter in the conversion string and save it, is the string still there and correct when you open that setting again?

- Have you cleared your browsers cache?

- Try turning off all of the cache settings for this addon to see if that makes a difference.

- Run the Tools->Database Tables script to convert all tables to utf8.

- Replace the conversion string with something like a=>b and refresh the shop side. If the a's are not changed to b's, then the problem is with the code, as opposed to type of character.

[Icebird]

On 3/14/2019 at 1:20 AM, Jack_mcs said:

I don't have a shop setup that uses more than English and is running with php 7 so I've no way to test this. You don't say what "its not working" means or what version of this addon you are using so I can only guess at things to try. The following are all I can think of:

Im using this version:

/**
 * updated for 2.3.4.1. CE Frozen and PHP 7.2
 * Rainer Schmied
 * @raiwa
 * [email protected]
 * www.oscaddons.com
 */
/**
 * Ultimate SEO URLs Contribution - osCommerce MS-2.2

 

On 3/14/2019 at 1:20 AM, Jack_mcs said:

- After you enter in the conversion string and save it, is the string still there and correct when you open that setting again?

Yes.. the string remains there as it was supposed to.

On 3/14/2019 at 1:20 AM, Jack_mcs said:

- Have you cleared your browsers cache?

Yes, Have tried it in sevral machines cross-browsers

On 3/14/2019 at 1:20 AM, Jack_mcs said:

- Try turning off all of the cache settings for this addon to see if that makes a difference.

nothing changes

On 3/14/2019 at 1:20 AM, Jack_mcs said:

- Run the Tools->Database Tables script to convert all tables to utf8.

All tables are in utf8mb4

On 3/14/2019 at 1:20 AM, Jack_mcs said:

- Replace the conversion string with something like a=>b and refresh the shop side. If the a's are not changed to b's, then the problem is with the code, as opposed to type of character.

That works. changing a=>b does work fine. Its just not the fancy letters that doesnt.

This is very annoying if you have several language packs.

 

[Icebird]

Just found the problem. its in your DB fix.

Changed in the classes/seo.class.php:

function ConnectDB() {
    global $db_link;
    $this->link_id = $db_link;
}

function ConnectDB_Legacy(){
  $this->link_id = mysqli_connect($this->host, $this->user, $this->pass, $this->db);
  if (!$this->link_id) {
    die('Connect Error (' . mysqli_connect_errno() . ') ' . mysqli_connect_error());
  }
} # end function

back to:

function ConnectDB(){
                $this->link_id = mysqli_connect($this->host, $this->user, $this->pass, $this->db);
        if (!$this->link_id) {
    die('Connect Error (' . mysqli_connect_errno() . ') '
            . mysqli_connect_error());
}
        } # end function

 

and now it is working again.

[Jack_mcs]

Thanks for posting the fix. I tested it in a shop that is using 5.6 and a second language and it does fail with the new function in it.

[BrockleyJohn]

1 hour ago, Jack_mcs said:

Thanks for posting the fix. I tested it in a shop that is using 5.6 and a second language and it does fail with the new function in it.

hmmm... the only difference I can think of between the two versions of db connection is that osc's db connection has the sql_mode reset to avoid the group_by issue in mysql 5.7, here in functions/database.php

    @mysqli_query($$link, 'set session sql_mode=""');

Perhaps this resets something else that's needed for the multi-language store to handle characters properly. It would be a good idea to check that the seo_class doesn't start throwing mysql errors on 5.7 on a server with the default settings (not usual on shared hosting but common on vps)

[vampirehunter]

i installed the plugin

and it works, but is there a way to rewrite the URLs other than having just the product id in the url?

for example this is the product url

the url is www.mystore.com/store/--p-52.html

how to get the product name or category in there?

is it done in the .htaccess file?

ive set show category parent to true but only get the product id showing in url, no category name or product name

 

Edited April 1, 2019 by vampirehunter

[Jack_mcs]

17 minutes ago, vampirehunter said:

how to get the product name or category in there?

It should be there automatically. That could happen if you have Header Tags SEO installed and didn't run Fill Tags. If you don't have that installed, look for some other addon that changes the names.

[vampirehunter]

28 minutes ago, Jack_mcs said:

It should be there automatically. That could happen if you have Header Tags SEO installed and didn't run Fill Tags. If you don't have that installed, look for some other addon that changes the names.

i have a Edge installation and header tags SEO modules are installed in admin as default.

where is the fill tags part of it?

 

or do i need to install the seperate header tags seo plugin?

 

Edited April 1, 2019 by vampirehunter

[Jack_mcs]

1 hour ago, vampirehunter said:

i have a Edge installation and header tags SEO modules are installed in admin as default.

The code in Edge is "Header Tags SEO Reloaded" - a completely different set of code from HTS. For that one, make sure the title modules in admin->Modules->Header Tags are installed. I don't know if they are needed for Ultimate SEO to work but they should be enabled anyway.  Also, be sure the "Enable use Header Tags SEO as name?" option is off in the settings for this addon.

[vampirehunter]

2 hours ago, Jack_mcs said:

The code in Edge is "Header Tags SEO Reloaded" - a completely different set of code from HTS. For that one, make sure the title modules in admin->Modules->Header Tags are installed. I don't know if they are needed for Ultimate SEO to work but they should be enabled anyway.  Also, be sure the "Enable use Header Tags SEO as name?" option is off in the settings for this addon.

i checked everything and all is installed as it should. all the options in header tags seem ok.

but still not getting the category or product name in the URL.

just get this

mystore.com/store/--p-65.html

not sure why that is

is there any error checking script to see what is causing it

 

 

2 hours ago, Jack_mcs said:

The code in Edge is "Header Tags SEO Reloaded" - a completely different set of code from HTS. For that one, make sure the title modules in admin->Modules->Header Tags are installed. I don't know if they are needed for Ultimate SEO to work but they should be enabled anyway.  Also, be sure the "Enable use Header Tags SEO as name?" option is off in the settings for this addon.

 

[vampirehunter]

2 hours ago, Jack_mcs said:

The code in Edge is "Header Tags SEO Reloaded" - a completely different set of code from HTS. For that one, make sure the title modules in admin->Modules->Header Tags are installed. I don't know if they are needed for Ultimate SEO to work but they should be enabled anyway.  Also, be sure the "Enable use Header Tags SEO as name?" option is off in the settings for this addon.

i did error log check and it says this

PHP Warning:  mysql_fetch_array() expects parameter 2 to be long, string given in /home/test/mysite.com/store/includes/functions/database.php on line 225

[Jack_mcs]

@vampirehunterA php warning shouldn't cause this but when all else fails it is a place to start. Although that message doesn't mean it is caused by this addon. Try turning this one off and see if the error still occurs. If it does, it's not due to this addon.

Also look at the source of the page and see what is in <title></title>. Do that with this addon on and off to see if there is a difference.

Also, does the name of the product appear on the page? You may need to install the page title module.

Also, what version of php are  you using? This addon will work with 7.0 and probably 7.1.  If you are running above that, try lowering it to see if it  makes a difference.

[vampirehunter]

22 minutes ago, Jack_mcs said:

@vampirehunterA php warning shouldn't cause this but when all else fails it is a place to start. Although that message doesn't mean it is caused by this addon. Try turning this one off and see if the error still occurs. If it does, it's not due to this addon.

Also look at the source of the page and see what is in <title></title>. Do that with this addon on and off to see if there is a difference.

Also, does the name of the product appear on the page? You may need to install the page title module.

Also, what version of php are  you using? This addon will work with 7.0 and probably 7.1.  If you are running above that, try lowering it to see if it  makes a difference.

product title and category appear fine in the title, and on the breadcrumbs

the error log shows i only got the error after installing the seo urls.

i did the same install on another edge site and getting same issue

so it looks like something from the addon maybe is causing the error in log

 

 

 

Edited April 1, 2019 by vampirehunter

[vampirehunter]

1 hour ago, Jack_mcs said:

@vampirehunterA php warning shouldn't cause this but when all else fails it is a place to start. Although that message doesn't mean it is caused by this addon. Try turning this one off and see if the error still occurs. If it does, it's not due to this addon.

Also look at the source of the page and see what is in <title></title>. Do that with this addon on and off to see if there is a difference.

Also, does the name of the product appear on the page? You may need to install the page title module.

Also, what version of php are  you using? This addon will work with 7.0 and probably 7.1.  If you are running above that, try lowering it to see if it  makes a difference.

Everything is fine in title and in admin. Page title and category title modules are installed and set to true.

Everything shows perfect in breadcrumbs etc.

The php is 5.6 something running on the hosting.

 

For some reason, the seo urls just arent showing the category and the product names.

I followed the installation exactly and double checked. All code was added as specified and the 2 files uploaded also.

 

 

 

 

 

 

Edited April 1, 2019 by vampirehunter

[vampirehunter]

i checked everything again and cannot figure out why the url is not showing category or product name.

 

 

[vampirehunter]

i uninstalled it and php error went away so something in the addon code is giving issue, just impossible to work out what.