Header DOH!

mark27uk3 · December 16, 2004

Hi Guys,

I am having one of those days today when I can not see the wood for the trees.

Please take a look at my site, you will see the search fields I have added from a contribution however the problem is that for some reason the rest of the page below this is also set at 50%.

Please take a look at the code below and tell me what you think, I think it is a closing table tag that is missing but I am unsure as to where to put it to make the rest of the page resume back to 90%

<?php
/*
 $Id: header.php,v 1.42 2003/06/10 18:20:38 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License
*/

// check if the 'install' directory exists, and warn of its existence
 if (WARN_INSTALL_EXISTENCE == 'true') {
   if (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/install')) {
     $messageStack->add('header', WARNING_INSTALL_DIRECTORY_EXISTS, 'warning');
   }
 }

// check if the configure.php file is writeable
 if (WARN_CONFIG_WRITEABLE == 'true') {
   if ( (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) && (is_writeable(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) ) {
     $messageStack->add('header', WARNING_CONFIG_FILE_WRITEABLE, 'warning');
   }
 }

// check if the session folder is writeable
 if (WARN_SESSION_DIRECTORY_NOT_WRITEABLE == 'true') {
   if (STORE_SESSIONS == '') {
     if (!is_dir(tep_session_save_path())) {
       $messageStack->add('header', WARNING_SESSION_DIRECTORY_NON_EXISTENT, 'warning');
     } elseif (!is_writeable(tep_session_save_path())) {
       $messageStack->add('header', WARNING_SESSION_DIRECTORY_NOT_WRITEABLE, 'warning');
     }
   }
 }

// check session.auto_start is disabled
 if ( (function_exists('ini_get')) && (WARN_SESSION_AUTO_START == 'true') ) {
   if (ini_get('session.auto_start') == '1') {
     $messageStack->add('header', WARNING_SESSION_AUTO_START, 'warning');
   }
 }

 if ( (WARN_DOWNLOAD_DIRECTORY_NOT_READABLE == 'true') && (DOWNLOAD_ENABLED == 'true') ) {
   if (!is_dir(DIR_FS_DOWNLOAD)) {
     $messageStack->add('header', WARNING_DOWNLOAD_DIRECTORY_NON_EXISTENT, 'warning');
   }
 }

 if ($messageStack->size('header') > 0) {
   echo $messageStack->output('header');
 }
?>
<table border="0" width="90%" cellspacing="0" cellpadding="0" align="center">
 <tr class="header">
   <td valign="middle"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image(DIR_WS_IMAGES . 'oscommerce.gif', 'osCommerce') . '</a>'; ?></td>
   <td align="right" valign="bottom"><?php echo tep_image(DIR_WS_IMAGES . 'header_right.gif');?></td>
 </tr>
</table>
<table border="0" width="90%" cellspacing="0" cellpadding="1" align="center">
 <tr class="headerNavigation">
   <td class="headerNavigation">  <?php echo $breadcrumb->trail(' » '); ?></td>
   <td align="right" class="headerNavigation"><?php if (tep_session_is_registered('customer_id')) { ?><a href="<?php echo tep_href_link(FILENAME_LOGOFF, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_LOGOFF; ?></a>  |  <?php } ?><a href="<?php echo tep_href_link(FILENAME_ACCOUNT, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_MY_ACCOUNT; ?></a>  |  <a href="<?php echo tep_href_link(FILENAME_SHOPPING_CART); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CART_CONTENTS; ?></a>  |  <a href="<?php echo tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CHECKOUT; ?></a>   </td>
 </tr>
</table>
<?php 
//
// START  advanced search header  script insertion
//
//
?>
<?php

if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') )  {
?>
<table align="center" border="0" width="90%" cellspacing="0" cellpadding="1" align="center">
 <tr>
   <td align="center" class="infoBoxContents">
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td class="infoBoxContents" valign="middle" colspan="0">
 <?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<table border="0" cellspacing="0" cellpadding="1" align="center">
<tr>
<td class="infoBoxContents" valign="middle" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"')  ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo BOX_ADVSEARCH_CAT ?></td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><center><?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></center></td>
</form></tr> 
<?php } ?>
<?php 
//
// END advanced search header script insertion
//
//
?>


<?php
 if (isset($HTTP_GET_VARS['error_message']) && tep_not_null($HTTP_GET_VARS['error_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
 <tr class="headerError">
   <td class="headerError"><?php echo htmlspecialchars(urldecode($HTTP_GET_VARS['error_message'])); ?></td>
 </tr>
</table>
<?php
 }

 if (isset($HTTP_GET_VARS['info_message']) && tep_not_null($HTTP_GET_VARS['info_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
 <tr class="headerInfo">
   <td class="headerInfo"><?php echo htmlspecialchars($HTTP_GET_VARS['info_message']); ?></td>
 </tr>
</table>
<?php
 }
?>

If anyone can help me straighten this out I would be most grateful.

Thanks

Mark :thumbsup:

December 16, 2004

i didnt take a look at your code, i did a view source, saw you are callig two tables prior to the search fields, then you are calling another table just after that. you need to close immediately after the search . . .

mark27uk3 · December 16, 2004

Hi John,

Thanks for your quick reply!

Could you please have a look at the code and tell me exactly where to close it as I have tried several times without success.

Thanks

Mark

♥Vger · December 16, 2004

The best thing to do is to download and install a text editor like TextPad or Crimson editor, and compare your file against an unaltered version of the same file - which will pick out where the changes have been made.

Vger

mark27uk3 · December 16, 2004

This is the only major change that has been done, adding this code

<?php
//
// START  advanced search header  script insertion
//
//
?>
<?php

if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') )  {
?>
<table align="center" border="0" width="90%" cellspacing="0" cellpadding="1" align="center">
<tr>
  <td align="center" class="infoBoxContents">
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td class="infoBoxContents" valign="middle" colspan="0">
<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<table border="0" cellspacing="0" cellpadding="1" align="center">
<tr>
<td class="infoBoxContents" valign="middle" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"')  ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo BOX_ADVSEARCH_CAT ?></td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><center><?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></center></td>
</form></tr>
<?php } ?>
<?php
//
// END advanced search header script insertion
//
//
?>

Mark

boxtel · December 16, 2004

This is the only major change that has been done, adding this code

<?php
//
// START  advanced search header  script insertion
//
//
?>
<?php

if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') )  {
?>
<table align="center" border="0" width="90%" cellspacing="0" cellpadding="1" align="center">
<tr>
  <td align="center" class="infoBoxContents">
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td class="infoBoxContents" valign="middle" colspan="0">
<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<table border="0" cellspacing="0" cellpadding="1" align="center">
<tr>
<td class="infoBoxContents" valign="middle" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"')  ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo BOX_ADVSEARCH_CAT ?></td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>
<td class="infoBoxContents" valign="top" colspan="3"> </td>
<td class="infoBoxContents" valign="middle" colspan="3"><center><?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></center></td>
</form></tr>
<?php } ?>
<?php
//
// END advanced search header script insertion
//
//
?>

Mark

<{POST_SNAPBACK}>

try replacing it with this :

<?php

if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') ) {

?>

<tr>

<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>

<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>

</form>

</tr>

</table>

<?php

}

?>

mark27uk3 · December 16, 2004

Hi Boxtel,

I have replaced the code and if you look at my site now you can see that the width is back to normal but the search fields are spread out right across the page instead of being centered.

Mark

mark27uk3 · December 16, 2004

I am nearly there at solving this little problem, I have had to jiggle the code around and this is what I have come with.

You can see it in action here

The only problem still outstanding is how to make the 'go' button valigned to the middle like the rest.

<?php 
//
// START  advanced search header  script insertion
//
//
?>
<?php
if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') ) {
?>
<table align="center" border="0" width="90%" cellspacing="0" cellpadding="0" align="center">
<tr>
<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<td class="infoBoxContents" valign="middle" colspan="2" align="center"><?php echo BOX_ADVSEARCH_CATA ?>  <?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"') ?>  <?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?>  <?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></td>
</form>
</tr>
</table>
<?php
}
?><?php 
//
// END advanced search header script insertion
//
//
?>

Mark

boxtel · December 16, 2004

I am nearly there at solving this little problem, I have had to jiggle the code around and this is what I have come with.

You can see it in action here

The only problem still outstanding is how to make the 'go' button valigned to the middle like the rest.

<?php 
//
// START  advanced search header  script insertion
//
//
?>
<?php
if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') ) {
?>
<table align="center" border="0" width="90%" cellspacing="0" cellpadding="0" align="center">
<tr>
<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<td class="infoBoxContents" valign="middle" colspan="2" align="center"><?php echo BOX_ADVSEARCH_CATA ?>  <?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"') ?>  <?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?>  <?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></td>
</form>
</tr>
</table>
<?php
}
?><?php 
//
// END advanced search header script insertion
//
//
?>

Mark

<{POST_SNAPBACK}>

make your button a separate <td></td> then you can use this:

mark27uk3 · December 16, 2004

boxtel,

I have/had done that, but if you look at the site now it pushes the button way over to the right.

The only way I can keep it next the actual search fields is to have in the same <td> tag.

Any ideas on how to get around that one

Mark

boxtel · December 16, 2004

boxtel,

I have/had done that, but if you look at the site now it pushes the button way over to the right.

The only way I can keep it next the actual search fields is to have in the same <td> tag.

Any ideas on how to get around that one

Mark

<{POST_SNAPBACK}>

I always but 1 <td width="100%"></td> in the beginning

and the same one at the end.

that will crush your content to the middle.

mark27uk3 · December 16, 2004

Sorry Amanda,

All that did was push everything to the left and split it between 2 lines.

Can you add what you mean to the code about 3 posts up so I can make sure I am doing it right.

Mark

boxtel · December 16, 2004

Sorry Amanda,

All that did was push everything to the left and split it between 2 lines.

Can you add what you mean to the code about 3 posts up so I can make sure I am doing it right.

Mark

<{POST_SNAPBACK}>

sure :

<?php

//

// START advanced search header script insertion

//

?>

<?php

if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') ) {

?>

<tr>

<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>

<td class="infoBoxContents" valign="middle" colspan="2" align="center"><?php echo BOX_ADVSEARCH_CATA ?> <?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"') ?> <?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?> <?php echo tep_image_submit('button_searcha.gif', BOX_HEADING_ADVSEARCH); ?></td>

</form>

</tr>

</table>

<?php

}

?><?php

//

// END advanced search header script insertion

//

?>

try this.

mark27uk3 · December 16, 2004

Hi Amanda,

Take a look at my site now, that has pushed everything into the right hand column.

Mark

boxtel · December 16, 2004

Hi Amanda,

Take a look at my site now, that has pushed everything into the right hand column.

Mark

<{POST_SNAPBACK}>

you may have to put some nowrap in there.

what I use myself:

</table>

<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'GET') ?>

<table bgcolor="#D8E8F5" border="0" width="<?php echo CENTER_HEADER_WIDTH; ?>" cellspacing="0" cellpadding="0" align="center">

<tr>

</tr>

<tr >

<?php if (!stristr(basename($PHP_SELF),'log')) {

echo tep_customer_greeting();

}

?>

</td>

<td valign="middle" ><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>

</tr>

<tr>

</tr>

</table>

</form>

<tr>

</tr>

boxtel · December 16, 2004

you may have to put some nowrap in there.

what I use myself:

</table>

<?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'GET') ?>

<table bgcolor="#D8E8F5" border="0" width="<?php echo CENTER_HEADER_WIDTH; ?>" cellspacing="0" cellpadding="0" align="center">

<tr>

<td height="5"></td>

</tr>

<tr >

<td class="boxtext" valign="middle" width="40%">

<?php if (!stristr(basename($PHP_SELF),'log')) {

echo tep_customer_greeting();

}

?>

</td>

<td nowrap valign="middle" ><font size="2"><?php echo BOX_HEADING_SEARCH . ' ';?></font></td>

<td valign="middle" ><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>

<td nowrap valign="middle" ><font size="2"><?php echo ' ' . BOX_SEARCH_TEXT_FOR . ' ';?></font></td>

<td valign="middle" ><?php echo tep_draw_hidden_field('inc_subcat','1') . tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH) . 'px"') ?></td>

<td valign="middle" > </td>

<td valign="top" ><center><?php echo tep_image_submit('go.gif', BOX_HEADING_ADVSEARCH); ?></center></td>

<td width="40%"></td>

</tr>

<tr>

<td height="5"></td>

</tr>

</table>

</form>

<tr>

<td><?php //echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>

</tr>

<{POST_SNAPBACK}>

that works out like this:

www,crystallight.com.tw

mark27uk3 · December 16, 2004

Thanks Amanda,

I have fiddled with it to get it right for my site and now it is working perfectly!

Thank You Very Much!

Mark

boxtel · December 16, 2004

Thanks Amanda,

I have fiddled with it to get it right for my site and now it is working perfectly!

Thank You Very Much!

Mark

<{POST_SNAPBACK}>

You are welcome, always a difficult thing those table tags, wrestling with it myself every day.

djmatrix · March 1, 2005

<?php
if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') ) {

?>

I seem to be having a problem with this little bit of code..

For some reason when i log in the search bar does not show at all.... I use OSC 2.2 M2, PHP 5...

i also use the logon box on the right coloumn..... If i // the code then everything works fine...

Please help....

March 1, 2005

Hi Dean,

The code your looking is saying that if it is not checkout.php and not create_account.php ... and not registered then do this ....

Once you register / login then the the code after it will not show !!

PhilipH

djmatrix · March 2, 2005

Hi Dean,
The code your looking is saying that if it is not checkout.php and not create_account.php ... and not registered then do this ....

Once you register / login then the the code after it will not show !!

PhilipH

<{POST_SNAPBACK}>

Ahh right... Well according to the contribution the search bar is not ment to show on checkout.php and create_account.php and advanced_search.php... do you know what i should do with the code to make that happen..as i am not a programmer..

Thanks in advance....

Header DOH!

Recommended Posts

mark27uk3

Guest

mark27uk3

♥Vger

mark27uk3

boxtel

mark27uk3

mark27uk3

boxtel

mark27uk3

boxtel

mark27uk3

boxtel

mark27uk3

boxtel

boxtel

mark27uk3

boxtel

djmatrix

Guest

djmatrix

Archived

Browse

Activity