Cart doesn't work with FireFox

[mattolsen]

My shopping cart won't work in FireFox. Everything is cool until you try to "Add to Cart" then it tries to resolve some bizzarre URL and that's it, dead in the water. It works fine in IE, but not FireFox. Anybody know what's up? Just try to add anything to the cart to duplicate the problem. Here's the new DEVELOPMENT site:

 

http://oclove.com/cart2/

 

And here's the LIVE site. Same problem with both of them:

 

http://oclove.com/cart/

 

Here's an example of the URL it tries to resolve when you click "Add to Cart" in Firefox:

http://oclove.com/cart/%3C/a?osCsid=302e94...0%3Ctd%20align=

[Guest]

It's not Firefox...it's your code in product_info.php. This is what is rendered:

          <tr>
           <td class="main"><a href="</a></td>
           <td align="right class="main"><input type="hidden" name="products_id" value="35"><input type="image" src="includes/languages/english/images/buttons/button_in_cart.gif" border="0" alt="In Cart" title=" In Cart "></td>

         </tr>

Clean up your code and hit save...

[thecodingmonkey]

It's not Firefox...it's your code in product_info.php.  This is what is rendered:

 ? ? ? ? ?<tr>
? ? ? ? ? ?<td class="main"><a href="</a></td>
? ? ? ? ? ?<td align="right class="main"><input type="hidden" name="products_id" value="35"><input type="image" src="includes/languages/english/images/buttons/button_in_cart.gif" border="0" alt="In Cart" title=" In Cart "></td>

? ? ? ? ?</tr>

Clean up your code and hit save...

<{POST_SNAPBACK}>

 

 

Firefox is a proper browser as does not accept every peice of garbage you type in

[Guest]

Firefox is a proper browser as does not accept every peice of garbage you type in

<{POST_SNAPBACK}>

Did I say Firefox was not a proper browser?

 

Look at the code that is rendered:

<tr>
          <td class="main"><a href="</a></td>
          <td align="right class="main"><input type="hidden" name="products_id" value="35"><input type="image" src="includes/languages/english/images/buttons/button_in_cart.gif" border="0" alt="In Cart" title=" In Cart "></td>

        </tr>

Notice that the a (href) tag is started but not closed and continues into the closing tag and onto the td's. This garbage is unacceptable to ANY browser. I checked it in Mozilla, IE, Firefox, and Opera.

 

My feedback to him was not directed to choice of browser but a fact of the matter. His code is dirty in product_info.php and is most likely due to the fact that he tried to remove the review button improperly.

 

So, it does not matter as to choice of browser...garbage is garbage.

 

My feedback stands: clean up the code in product_info.php and hit save.

[Guest]

Firefox is a proper browser as does not accept every peice of garbage you type in

<{POST_SNAPBACK}>

My apologies for the last reply...someone is DOS attacking my datacenter where my dedicated server is colocated so I'm a bit testy today.

 

* I will step away from the keyboard until they filter their router and I return to my happy self *

 

Once again, my apologies...

 

Bobby

[mattolsen]

D*mn you guys are good! Thanks! That was exactly it. For some reason on my computer it still works in IE even with the junk code. I replaced product_info.php with a clean copy and it's fine now.

 

So........... How do I properly remove the review feature?

[Guest]

For some reason on my computer it still works in IE even with the junk code.  I replaced product_info.php with a clean copy and it's fine now.

<{POST_SNAPBACK}>

Now what does that say about IE? :-"

[Guest]

Now what does that say about IE? :-"

<{POST_SNAPBACK}>

...which is exactly what thecodingmonkey was trying to get across in his reply but I flew off the handle due to my frustration with the datacenter DOS attack.

 

Does it show that I feel badly about my reply? :(

[Guest]

...which is exactly what thecodingmonkey was trying to get across in his reply but I flew off the handle due to my frustration with the datacenter DOS attack.

 

Does it show that I feel badly about my reply?  :(

<{POST_SNAPBACK}>

Well, sorta.............. :P

[Guest]

...

So........... How do I properly remove the review feature?

<{POST_SNAPBACK}>

In product_info.php find this code:

                <td class="main"><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>

...and replace with this:

                <!--
   <td class="main"><?php #echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>
   //-->

[Guest]

In product_info.php find this code:

                <td class="main"><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>

...and replace with this:

                <!--
   <td class="main"><?php #echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>
   //-->

<{POST_SNAPBACK}>

I am inclined to agree with Bobby here. Whenerer I need to remove something, I always <!-- comment it out -->. That way I can always add it back if I need to.

[♥Vger]

That IE is a far more sophisticated browser, and with more redundancy built into it. Don't get me wrong, Firefox is a nice little browser - emphasis on the 'little'! Interesting that Firefox's best skin is the IE skin.

 

Vger

Now what does that say about IE? :-"

<{POST_SNAPBACK}>

[burt]

That IE is a far more sophisticated browser, and with more redundancy built into it.

<{POST_SNAPBACK}>

 

Did you forget the sarcasm smiley? :D

[♥Vger]

Nah! I didn't. I genuinely like Firefox. It's a nice browser. The day may come when it even makes an impression on my web stats! I do cross-reference to it for coding, so that my sites render well on it - but that's as far as it goes really.

 

I was discussing this the other day with someone who was saying that on a 'techie' forum site he was getting almost 50% of his hits from Firefox. I did a comparison with an active e-retail website I host, where it doesn't even get a listing - even Konqueror managed 0.22%.

 

Still, the day may come when it poses a threat to Microsoft - and then Microsoft will buy them out and bury it.

 

Vger

Did you forget the sarcasm smiley?  :D

<{POST_SNAPBACK}>

[bglkk]

I was discussing this the other day with someone who was saying that on a 'techie' forum site he was getting almost 50% of his hits from Firefox.  I did a comparison with an active e-retail website I host, where it doesn't even get a listing - even Konqueror managed 0.22%.

Vger

<{POST_SNAPBACK}>

 

Both of those sets of figures are extremes, I reckon. My site (computer upgrade products) has had 720,414 hits with Firefox in November--good for 16.9% (IE has dropped to 74.9%). That's a pretty dramatic shift--Firefox only had 8.9% in October, and it wasn't on my charts in Sept. Luv ya, Firefox! :thumbsup:

[Guest]

That IE is a far more sophisticated browser, and with more redundancy built into it.

sorry English is not my native language, but I assume redundancy is another word for bugs here :lol:

[241]

Please stick to the thread topic instead of deviating with FUD