Multi_Vendor_Shipping new thread

[drillsar]

That's what I thought, I wasn't sure. I also found a bug in /catalog/include/classes/vendors.php when upgrading to 2.3

 

the line read:

 

reset($modules_array);

foreach ($installed_modules_array as $value) {

$class = substr($value, 0, strrpos($value, '.'));

$include_modules[] = array('class' => $class,

'file' => $value);

 

THe Change:

 

foreach ($installed_modules_array as $value) {

reset($modules_array);

$class = substr($value, 0, strrpos($value, '.'));

$include_modules[] = array('class' => $class,

'file' => $value);

 

Otherwise it was giving a error

[♥kymation]

That is a bug, but your fix is still incorrect. The correct code should be:

 

       reset($installed_modules_array);
       foreach ($installed_modules_array as $value) {
         $class = substr($value, 0, strrpos($value, '.'));
         $include_modules[] = array('class' => $class, 
                                    'file' => $value);
       }//foreach

Fixed in the master copy. Thanks for the bug report.

 

Regards

Jim

Edited December 28, 2010 by kymation

[alman]

Warning: strpos() expects parameter 1 to be string, array given in C:\xampp\htdocs\storelive\includes\classes\vendor_shipping.php on line 46

 

Warning: substr() expects parameter 1 to be string, array given in C:\xampp\htdocs\storelive\includes\classes\vendor_shipping.php on line 46

if ( (tep_not_null($module)) && (in_array(substr($module['id'], 0, strpos($module['id'], '_')) . '.' . substr($PHP_SELF, (strrpos($PHP_SELF, '.')+1)), $modules_array)) ) {

 

change it to

if ( (is_string($module) && (tep_not_null($module)) && (in_array(substr($module['id'], 0, strpos($module['id'], '_')) . '.' . substr($PHP_SELF, (strrpos($PHP_SELF, '.')+1)), $modules_array))) ) {

 

and it is causing ot_shipping to through the same errors as well

$module = substr($GLOBALS['shipping']['id'], 0, strpos($GLOBALS['shipping']['id'], '_'));

so change it to

 

$module = is_string($GLOBALS) && (substr($GLOBALS['shipping']['id'], 0, strpos($GLOBALS['shipping']['id'], '_')));

 

hope this helps

Al

Edited December 29, 2010 by alman

[♥kymation]

It's been quite a while, but I think I remember this one. If I'm right, you're missing the code that deals with arrays being passes to the module. Now if I can just remember where that code is....

 

Regards

Jim

[drillsar]

Paypal Express seems more complicated to get MVS to work. I looked at function confirmation on the express and is way different then paypal ipn.

 

 

Is there any more bugs that your aware of?

[♥kymation]

No, I fix anything that I find or that someone tells me about. Paypal has always been a problem, and any other payment "module" that bypasses the osCommerce checkout will also be a problem.

 

Regards

Jim

[drillsar]

Thanks for all your help.

[Guest]

Has any one got module PayPal (WPP) PayPal Pro - Direct Payment & Express Checkout, to work with this module MVS?

 

The direct payment part works its juts the express checkout doesn't, after you clicked the express button it takes you to paypal you login etc then go back to the site to select postage, when selected postage it then takes you to the payment page?? (which i have disabled)(its like it forgets its express checkout?!?!?)

 

thanks for you help

regards

[drillsar]

Express Checkout don't work yet as mentioned above, I'm sure it's going to be worked at.

[drillsar]

I have a slight problem, one of my vendors has prices per item so I tried to setup individual price but how do I actually setup prices on the item?

 

I see there is a products_ship_price but how do I add it?

[♥kymation]

You should be able to add that in with the rest of your product information. If the shipping price field is not showing up, you probably have an error in your installation somewhere in admin/categories.php.

 

Regards

Jim

[drillsar]

Thanks Jim, I will take a look, I added some other contributions maybe I messed it up.

[drillsar]

shipping price field is not showing up

 

I even used the default MVS admin/categories.php, I dont see a text entry for shipping price field in the categories, do I have to add it?

 

in product_query it looks like Mvs dont have it:

 

//MVS

$product_query = tep_db_query("select products_quantity, products_model, vendors_prod_id, products_image, products_price, vendors_product_price, vendors_prod_comments, products_date_added, products_date_available, products_weight, products_status, products_tax_class_id, vendors_id, manufacturers_id from " . TABLE_PRODUCTS . " where products_id = '" . (int)$products_id . "'");

$product = tep_db_fetch_array($product_query);

 

So I guess I have to add it but I thought indiv shipping was in the MVS

Edited January 4, 2011 by drillsar

[drillsar]

I had to add it in categories.php, I thought MVS already had that in there.

 

should I share code?

[♥kymation]

Individual Shipping is available to use with MVS but is not installed. See the Individual Shipping module folder in the Extras folder.

 

Regards

Jim

[drillsar]

Individual Shipping is available to use with MVS but is not installed. See the Individual Shipping module folder in the Extras folder.

 

Regards

Jim

 

I did that but admin/categories.php is missing there or am I missing something?

[♥kymation]

You may have to go to the original Individual Shipping Addon for some of the files.

 

Individual Shipping is not really a part of MVS. Somebody modified it to work with MVS and put the modified files in the Extras folder. There are no instructions so I'm assuming it's incomplete.

 

Regards

Jim

[drillsar]

Yeah it's not complete, im about finished with that.

 

I took a look at vendors.php, did anyone add Country State Selector to this?

[drillsar]

Hey Jim,

 

I see a problem with Individual SHipping if vendor has another shipping method, so im assuming this is the problem:

 

$this->vendor_shipping[$vendors_id]['cost'] += tep_add_tax($products_price, $products_tax) * $quantity;

 

Im guessing this will have to be changed to:

 

$this->vendor_shipping[$vendors_id]['cost'] += tep_add_tax($products_price, $products_ship_price, $products_tax) * $quantity;

 

Individual shipping works but alot was missing, again though if vendor has multiple shipping carriers it dont add the individual shipping as well, Im thinking this is the fix for that.

 

Does that look right?

 

I'm almost done converting this to 2.3.1 the only thing thats not done is the shipping estimator so Im going to leave that out for now.

[♥kymation]

That won't work unless you've modified tep_add_tax(). Maybe you want this:

$this->vendor_shipping[$vendors_id]['cost'] += tep_add_tax($products_price + $products_ship_price, $products_tax) * $quantity;

 

That will force the store to add tax on shipping. Not everyone wants that, so it should be an option, not required.

 

I don't see how that will affect the Individual Shipping not being added in. That code only fixes shipping tax, not the whole amount. There's probably some other bug in Individual Shipping if it's not being added in.

 

Regards

Jim

[drillsar]

Yeah, It adds Individual pricing but lets say you have also UPS, it will do Indiv pricing of $4.00, UPS of $15.00 so you can select 4.00, I will figure whats going on here.

 

I figured that was for tax.

[♥kymation]

If you want Individual pricing to be the only choice, you need to assign it as the only module for that vendor. As long as there are multiple modules there will be multiple choices.

 

Regards

Jim

[drillsar]

What im saying is if you have multiple shipping per vendor like UPS and Indiv shipping, both of them are displayed, shouldnt the indiv ship add it to the UPS Method?

 

Example lets say I have a keyboard and shipping is $4.00 (Indiv SHipping), and they buy a video card that uses weight of 2lbs, UPS price is 6.23+Indiv shipping price total of $10.23 currently it shows $6.23 and $4.00 or this isnt possible?

[♥kymation]

Yes you can do that. Assign the keyboard to the vendor that has Individual Shipping set up and the video card to the vendor that has UPS set up. The shipping costs will be added up on the shipping page.

 

Regards

Jim

[drillsar]

Yes you can do that. Assign the keyboard to the vendor that has Individual Shipping set up and the video card to the vendor that has UPS set up. The shipping costs will be added up on the shipping page.

 

Regards

Jim

 

It wouldn't work with the same vendor correct?