Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Owl Sauron

Members
  • Content count

    130
  • Joined

  • Last visited

  • Days Won

    2

Reputation Activity

  1. Like
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    A new version has been uploaded with these changes:
    Corrected many compatibility issues found by member @Owl Sauron 
    Removed unnecessary jquery code. Found ny member @MyBookShop,
     
  2. Thanks
    Owl Sauron got a reaction from Jack_mcs in Jssor Slider   
    Ok... had a few mins free and took a look at it and found the problem. Its with the number of installed languages you have on the shop. It will show the HTML Text for each language for the same slide generating (slide * languages) slides.

    Since i wont use any HTML Text on the banner i simply did a "quick fix" for the header module as:
    Edit file "tpl_cm_header_jssor.php" replacing from line 5 to 16 the following code:
    "
    $banner_query = tep_db_query("select a.advert_id, a.advert_url, a.advert_image, ai.advert_html_text
                       from advert a left join advert_info ai using(advert_id)
                         where advert_group = '" . MODULE_CONTENT_HEADER_JSSOR_SLIDER_GROUP . "' and status = 1");
    if (($cnt = tep_db_num_rows($banner_query)) > 0) {
        while ($banner = tep_db_fetch_array($banner_query)) {
            if (tep_not_null($banner['advert_image'])) {
                $imgArray[] = tep_image('images/' . $banner['advert_image'], $banner['advert_html_text'], '','','u="image"');
                $txtArray[] = $banner['advert_html_text'];
            } else  {
                $imgArray[] = $banner['advert_html_text'];
            }
    "
    with:
    "
    $banner_query = tep_db_query("select advert_id, advert_url, advert_image from advert where advert_group = '" . MODULE_CONTENT_HEADER_JSSOR_SLIDER_GROUP . "' and status = 1");
    if (($cnt = tep_db_num_rows($banner_query)) > 0) {
        while ($banner = tep_db_fetch_array($banner_query)) {
            if (tep_not_null($banner['advert_image'])) {
                $imgArray[] = tep_image('images/' . $banner['advert_image'], '', '','','u="image"');
            }
    "
    its just an headsup so you dont waste time looking for the bug and can fix the problem when you update the module but might be handy for someone else in the meanwhile.
     
    Tested on Phoenix 1.0.8.0
    PHP 7.0
  3. Thanks
    Owl Sauron reacted to Jack_mcs in Jssor Slider   
    Then it must be due to compatibility with the version of your shop since the problem doesn't exist in others. I'll check that before uploading a new version.
  4. Like
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    I'm tying for 2-4 weeks.
  5. Like
    Owl Sauron reacted to Jack_mcs in HoneyPot Captcha   
    For the telephone error, change this
    $telephone = $customer_details['telephone']; to
    $telephone = ($customer_details['telephone'] ?? null); You can do similar for the street address but that should be enabled so you may not have your modules setup completely,
    For the last error, I see I didn't copy the new post code list to admin. To fix that, in includes/functions/honeypot.php copy lines 239 through 404 and copy them over lines 70 through 88 in admin/includes/functions/honeypot.php.
  6. Haha
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    Thanks for pointing out the typo. It has been that way from when it was first added but was never noticed.
  7. Thanks
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    A new version has been uploaded with these changes:
    Changed the code in the HTS display module in admin to prevent php warnings. Changed the code in the HTS test file in admin to prevent php warnings. Changed the code in admin/categories.php to automatically fill in the stock SEO fields. Found by @alix32. Changed code on the keywords page to fix errors in the position code. Changed code in the test file to fix errors. Changed code in the Version Checker for php warning. Corrected link in Version Checker that gave incorrect results. Corrected the install instructions. Found by @geoffreywalton. Moved the keyword search handler to a hook in Phoenix. Removed some unused defines left over from a previous version. Notes:
    1 - The only changes are for the -14 and -15 Phoenix versions. Though the -14 changes will apply to some previous versions.
    2 - Don't rely on the change instructions for the categories.php file. Due to the changes to that file with each Phoenix release, it is just not feasible to keep the install instructions updated. Use a compare program to find the needed changes.
  8. Like
    Owl Sauron reacted to burt in Header Tags SEO   
    Core is always evolving and getting better, it will eventually end up in a place where everything can be done without core being affected at all.  To get to that place means some "hurt" for existing addons. What we have is a small team of addon developers who are actively involved in helping Matt @ecartz and myself to "bend" the core code to better suit their addon needs, which means their addons become much easier to install.
    Think back to the days of 2.2 (or even 2.3) where you would see addons changing core code on lots of different pages to do something.  We've massively reduced that with the help of supportive addon makers and supportive shopowners.  
    On the flip side of that coin are the addon makers and shopowners who have zero input into the core code.  If one has zero input, one should expect to have to deal with problems as they arise, rather than know upcoming problems in advance.
    I can summarise this as so:
    The core does not stand still because of addons.  
  9. Like
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    The changes in Phoenix will sometimes change the code to where it is no longer recognized by the code in addons. For example, a function may be moved to a class so the code in the addon can't find the function any longer. There's no way for developers to plan for this so we just have to react after the fact. But as soon as we upload a new version of the addon, the code in Phoenix changes and breaks the addon again. Testing the addon with the new version of Phoenix, identifying the new problems, fixing the code and then uploading the new version of an addon is not a small job so upgrading can't be done for every version of Phoenix. Unfortunately, there's just no way around it.
  10. Sad
    Owl Sauron reacted to Jack_mcs in Header Tags SEO   
    A version for 1.0.7.14 hasn't been released.
  11. Like
    Owl Sauron got a reaction from kgtee in Support thread for JcM Bank Transfer Payments V1.0 Phoenix   
    Sorry for the late submit but took a bit more than expected.
    feel free to use it.

    https://apps.oscommerce.com/beYqB&bank-transfer
  12. Like
    Owl Sauron got a reaction from kgtee in Support thread for JcM Bank Transfer Payments V1.0 Phoenix   
    Sorry for the late submit but took a bit more than expected.
    feel free to use it.

    https://apps.oscommerce.com/beYqB&bank-transfer
  13. Like
    Owl Sauron got a reaction from valquiria23 in Support thread for JcM Bank Transfer Payments V1.0 Phoenix   
    I will update that module for 1.0.7.14 and publish it later today if i can.
  14. Like
    Owl Sauron got a reaction from valquiria23 in Support thread for JcM Bank Transfer Payments V1.0 Phoenix   
    I will update that module for 1.0.7.14 and publish it later today if i can.
  15. Like
    Owl Sauron got a reaction from Fredi in View Counter   
    Greetings again.
    Changing the DB to utf8 and the engine from InnoDB to MyISAM solved the problem.
    Yep, the new version has it all hardcoded, but that is not described in the installing manual. We have to compare the chnaged files. Please update the install manual.
    This module is a must in any installation. Keep it on!
    Many thanks for the support!
  16. Thanks
    Owl Sauron reacted to Jack_mcs in View Counter   
    Thank you for pointing that out. I see the other language files in that location also use the definition so they all need to be changed.
×